# Mapcomplete Marketplaces

Note: see https://thenounproject.com/search/?q=fish&i=3865323 for a huge icon collection, often with cc

Notes from Thibault/Marc
Is it just me btw, but doesn't seem like I can add any nodes with that mapcomplete theme on osmbe
EDIT:

id editor uses building(yes or no) instead of indoor btw. Just good to know I guess
Seems like something Is wrong, because i just added openinghours to a market in mapcoplete, but it still says "open on 0 days of the week"
Seems like your theme doesn't have a second prebuild answer for ìndoor`, which could be 'no' I guess
"A name is required in order to display and create reviews", yet no way to enter name
Consider adding bread and cheese to the list of 'things sold' (as seperate items)

Marc_marc (@marc_marc:matrix.org)
the one who rents has in my opinion the same rights as if he was owner
Marc_marc (@marc_marc:matrix.org)
building<>indoor is orthogonal (building=yes mean the whole building is used for the marketplace, but without building=yes it could be an outdoor marketplace or an indoor marketplace not using the whole building
joost_schouppe

Thanks Thibault!

yes, I forgot about adding a "preset" for adding new POI
for indoor/outdoor, I tried to use building=* and indoor=* to detect it. That's why there's no explicit "outdoor" answer option: that's the default. I think I add "indoor=yes" because I think it makes no sense adding building=yes to a node that might be inside of a building. But I'll look at that again
Right, the name! I also saw that Pieter now has a workaround to review unnamed features too
I wanted to keep the list short, my idea is that in almost all cases, it should be possible to limit to one or two "sells" value. As in: I don't want users to map the catalog of items, but rather just have a "general" idea of the market. So all the topics listed there are things you might expect to be the single specialty of the market. Do you think that makes sense?

Marc_marc (@marc_marc:matrix.org)

building<>indoor is orthogonal (building=yes mean the whole building is used for the marketplace, but without building=yes it could be an outdoor marketplace or an indoor marketplace not using the whole building

Perhaps any change to indoor/building through mapcomplete should trigger a fixme? This kind of subtlety cannot be properly addressed within mapcomplete
Very useful feedback, you two!
Marc_marc (@marc_marc:matrix.org)
can a question modify 2 tags? a question with 3 choices solves the problem: 1) use the whole building 2) use a part of a building -> indoor=yes 3) outdoor -> indoor=no
choice 1 seems to me difficult to do automatically if the market is tagged with a node. i don't even know if it's desirable to encourage the creation of building+market object considering all the problems it causes
joost_schouppe
I've seen similar issues with marketplace+parking on one area. Before you know it, you mix up tags

Van Thibault nog: kaas en brood te koop

Notes from Pieter
Voor de 'origin'-tag, misschien vragen 'on what origin does this market focus', met dan als antwoorden bv: "local, asian, african, european, turkish, ..." Dan is het vrije tekstveld daar ook wat logischer en kan je ook dat soort markten meenemen. Zie taginfo voor inspiratie. (Je kan die vraag ook enkel tonen wanneer er iets van voedsel wordt verkocht

Daarnaast: je kan in de svgs voor de dagen van de week omvormen, zodat je geen tekstvelden maar paden van die font hebt. Er wordt immers meegestuurd "render deze tekst in dat font", maar niet iedere computer heeft dat font wat een beetje lelijk kan zijn (zie afbeelding)

## Main "types"
**Similar to *vending* tag?**
Re-use https://wiki.openstreetmap.org/wiki/Proposed_features/Sells
* if no "sells" tag: "general" market
* if a single "sells": use it in the header
* multiple:
-Food (as in a shop): genaral=grocery* i
- specific foods: fish, meat, vegetables, fruit*
-Food to eat instantly - some market specialize in "streetfood"*
-antique*
-books*
-handicrafts*
-art*
-flowers*
-clothes
-live animals*
-electronics
-second_hand* i
(https://github.com/pietervdvn/MapComplete/blob/master/assets/themes/facadegardens/facadegardens.json#L216)

**Extra info**
* organic >>> only if food
* local > "farmer's market"
* indoor> implied by building=* /outdoor > implied in all other cases
* opening hours (add a letter for every day it is open as a subicon; color green if open right now!) > calculated tags > see drinking_water regex and https://github.com/pietervdvn/MapComplete/blob/master/Docs/CalculatedTags.md vb `"calculatedTags": [ "_is_open_on_monday=feat.properties.opening_hours.matches(/mo/)"]`
* if open_on_monday=1 & today=monday then show the market extra clearly
* "weekly market" is impossible without properly parsing opening hours

## FAQ
* what if general market thrusday, flower market sunday? (e.g. Flagey)
* option 1: two nodes, easy peazy
* option 2: sells:conditional=flower@ Su
* what about "jaarmarkten" or markets that are "every last sunday of the month"
* what if building 24/7 accessible, but market opening hours specific? e.g. way/413300707 > per the wiki: separate objects
* What if there is a little sign indicating the presence of a market? Should we map those?
* Map the sign itself? Why?
* We should also add a note that the market might only be visible at certain times, in order to avoid well-meant (but incorrect) deletions
* I don't think so, the wiki makes it clear that "marketplace" is more about the event than the infrastructure (e.g. "it is weekly or daily", "map on a separate object if the same space is also a parking")