# Homework

1. Standup external gitea instance for collaboration and hacking - NOT DONE, BUT COMING SOON
2. Decision Record document (lwhsu, ...)

# Minutes

lwhsu: use this meeting to add more content to the [decision record doc](https://hackmd.io/UZ-C4dceTRmlT1wKCyWjjw)

ihor: failed to standup gitea server due to cloud provider issues

lwhsu: (describes the document)
ihor: server-side hooks vs client-side.
lwhsu: most hooks are server-side, coming still from CVS. We do have some client side hooks, mostly in ports.

warner: client-side hooks for checking commit messages are important, we need those hooks in public repository where people can see it, and it would be nice to have it as short-term priority.

lwhsu: the checkers (lint or sanity) can be in independent sccript and executed by both client and server side hooks

warner:
we need to have a an escape-hatch to disable certain checks, vendor code for example is outside of our control and we need to make exceptions. We need to integrate clang-format. There are
cases of code that need to be exempt from clang-format.
Another comment - integrate with MAINTAINERS/CODEOWNERS. Convert MAINTAINERS to CODEOWNERS standard format. Introduction of these tools ideally should be phased, to avoid shocking people.
We want to move more quickly, but listen to feedback and if something causes pain for people - we need to be able to dial down on certain things.

lwhsu: principle sections outlines the general approach. MAINTAINERS file is document, not configuration. We can convert automatically. Another option is to have to have a hook-script when PR/commit request is created it should check MAINTAINERs file and notify relevant maintainer/reviewer.

ihor/ed: codeowners is picked up by gitea and reviewers are added automagically to PR

lwhsu: codeowners is not branch aware. We will need some additional logic to add branch-specific rewivers (i.e. release engineering branches needs to have sign off by re engineer)

lwhsu: integration to mailing list and bugzilla currently is done by post-reeive hook, but as long as it can be done, git hook is not mandatory

using merge button will be a huge improvement to maintainer's workflow, especially ports.
lwhsu: How do we enforce good commit message? ihor: use CI + server side hooks

lwhsu: how to deal with MFC. This is not a common practice in opensource world.
ihor: use things like dependabot
ed: this can be done in the next phase of the rollout, for now current workflow is fine.

lwhsu: CI integartion is main prereq for the new workflow. How to implement? How to run locally?
one idea is to use current jenkins infrastructure, this is a drawback of compute power limitation.
ideally would be to use external on-demand compute resources.

---
# Action item
* check CODEOWNERS works for most hosting services/software (sortof done?)
* test out agit workflow - avoid "fork hell" (ihor)