Response to Problems

# Response to Problems ## general testing problem - only biased tester - no given test data ## Android APP [Till] *A dialog appears that new companion data has been unlocked but the app crashes when I click on it.* All the button would have done is take you to the Mood history screen. - Companion data is still available after the crash. - It should be very easy to fix. We'll look into it. --- [Till] *The agreement to the terms and conditions and the consent form are asked at the end of the registration process (T1-2) at the point when the user already entered all the information, so until that point I don’t know what the data will be used for. When the consent form has not accepted a message appears that not all questions have been answered.* - The data wont be uploaded until the consent form is confirmed - The order of the consent form and questionnaires can easily be changed by us so it shouldn't be a problem to fix this issue. - ((This issue exists because the consent form is treated as just another Questionnaire in code. Due to this I (Noah) expected the Web App interface to present a YAML text which describes the Questionnaires and the Consent Form where the Admin could change the order of the Questionnaires and the Consent Form themselves. So I didn't think the order mattered because I thought the admin could change it easily)) --- [Till] The first day (registration day?) the notifications didn’t work (T3-2) but the following days they appear. - This should work now --- [Till (& A)] When changing the password (T1-6) it has to been entered only once, no password verification: - We used a firebase functionality to reset and change the password. To verify the password we could implement the functionality ourselves. --- [Major problems] [A] Originally, the landing screen in the app was supposed to be a calendar. - We could implement this feature in the future, we decided against it now due to time constraints. We thought there were more important features to implement. But we probably should have communicated this more openly and discussed it with the client. --- *Inviting a companion through e-mail (T2-3) works in general, but there are a couple of flaws:* [Alejandra] - T2-3: The download link has nothing to do with the companion request itself, that might have been a missunderstanding. As long as a person has no registered moodey account an invite via email will be send containing a download link to the app on the other hand if they have an account a companion request will be send. If a user now registers with the email they should receive a companion request. **T2-3 Improvements:** We did not experience the unregistration issue ourselves by inviting via email so we did not know this exist. We think this could be fixed easily if we are able to reproduce the error. --- [A] Regarding the “Take a mood survey” functionality - The issue that led you to hard reset the app was likely a network error which wasn't handled properly, which leads to the indefinite loading screen. If this is the case, it should be easy to fix. --- [A] In the “companions” screen the option “Other” is missing. - This was missed due to time constraints, but if needed it can easily be added to the surveys --- I can always record special situations (it seems) - fixed in new patch --- [Alejandra + Till] *Notifications (T3-2) I did not receive notifications until today 20.08 (I have been testing since the weekend). Till received duplicated notifications, it seems.* - T3-2: The part of sending notifications a day later was intended but removed in the newest version of the app. Duplicated notifications might also happen this is caused by overlapping time ranges set by the admin. The implementation of the notifications feature was rather rushed because it was supposed to be implemented via cloud functions but couldn't be in the end (therefore we had to adept and implement it in android). **T3-2 Improvements:** If we would use the payed version of firebase an implementation via cloud functions would have been possible, which would send reliably and efficiently notification to a phone. --- [A] I was informed when the data from my companions was visible ... [Antwort bei Till] --- [Minor problems] --- [A] Is the e-mail confirmation used somewhere? - Nope but it could be used in the future to ensure better quality of the exported data. [A] As Till mentioned already... [Antwort steht bei Till] --- [A] The test case ‘add companion by code’ (T2-2) cannot be fulfilled without sending... - T2-2: Not sure what you mean by that could you go a bit more indepth? The add companion feature via code requires both users to use the app already, so you are not able to invite anyone via your code that is not already using the app. Sending your companion code to an existing user should work properly though. --- [A] After removing a companion (T2-5) which worked well on the app, the companion was not notified that I removed them. - We decided against this, because Moods might be influenced if the user gets a notification about a removed companion (was this even in the PROJECT_DESCRIPTION?) - We could implement this with a firebase function that is called if an user deletes a relationship document in the db and sends a notification to the user. ------------------------- ## Web APP - Cycle: stored as a string read as an int (I only tested if the value changed correctly) therefore the error [FIXED] - milliseconds/seconds since midnight Jan 1 1970: common format and firebase given (UNIX time) -> https://en.m.wikipedia.org/wiki/Unix_time - CSV: testing & debugging it was highly difficult for me since a full scale test, furthermore new additions and db structure changes where made until the very end which left nearly no time to test and debug possible errors - the csv file generation from a NO-sql & JSON-like db-structure is not easy (, and rather unnecessary (imo) since json is an easy to read data format as well, -> therefore the json) - the data is stored somewhere, due to time limitations we had no chance to provide a "get last generated data" button (- sorry, but accidentally closing a window is not our problem - this can happen with any kind of implementation) - in order to provide a proper downloadable file a file has to be uploaded to firebase storage therefore you need an actual file. the creation of such is not doable with js alone. - consent file can be downloaded in the consent setting - no relationship found (did you delete your relationship before generating? If yes this is the cause, if not I would have to check the file and get back to you.) - cannot vizualize special situation: possible, but not added this to the web app implementation ### improvements: implementing & debugging your mentioned points ## at the end thank you for your feedback When do you anticipate finishing marking