# Reviewing easyconfig PRs

https://octobox.io

https://docs.easybuild.io/en/latest/Contributing.html#review-process-for-contributions

## Reviewing

* visual review

* compare with existing easyconfigs via `eb --review-pr`
* limit scope via `--review-pr-filter` and `--review-pr-max`

* if a sanity check command is missing, try adding one (or ask contributor to add one)
* this is currently not strictly enforced

* old (deprecated) toolchains: close PR
* see https://docs.easybuild.io/en/latest/Deprecated-easyconfigs.html#deprecated-toolchains

* move from higher to lower toolchains e.g. `foss` to `GCCcore` where appropriate

`eb --sync-pr-with-develop`

## Testing

* always ask bot to test on `generoso`
* try to submit additional test report(s) yourself

## Merging

`eb --merge-pr`