Workgroup - PR Review
=============================================================================

###### tags: `workgroup`

## Workgroup Members

Reviewers: Mark, Anatolly, Simon, Mario, Francesco
* Assign labels (priority, needs more information, needs contribution) and review PRs

Senior Reviewers : Everyone of the [Core team](https://github.com/orgs/django-cms/teams/core-team)
* Merge PRs

## Workroup Leader

Francesco, Nicolai (moderator)

## Workgroup Goals

- Manage Github Issues & review Pull Requests

## Links

- [Guidelines of this work group](https://hackmd.io/dvqIkYS_QGmvzvujgkOqRw)
- [Github Issues](https://github.com/django-cms/django-cms/issues)
- [Github PRs](https://github.com/django-cms/django-cms/pulls)
- [Issue Management Guidelines ](https://docs.django-cms.org/en/latest/contributing/management.html#issues)
- [Github Issue / PR Review Guidelines](https://hackmd.io/dvqIkYS_QGmvzvujgkOqRw)
- [Contribution Response Templates](https://hackmd.io/@fverde/H1WTZoaIu)

# Meeting log

## 12.05.2021 (Next Week)

### Agenda

#### Issues to be reviewed (Submit your issue here)

-

#### High Priority Issues

- Maybe this one? https://github.com/django-cms/django-cms/pull/7014

### Tasks

- [ ] Come up with a clear process for how this work group conducts its weekly meeting (Nicolai)

## 05.05.2021

### Agenda

#### Issues to be reviewed (Submit your issue here)

- Issue [#6085](https://github.com/django-cms/django-cms/issues/6085)
- Issue [#6994](https://github.com/django-cms/django-cms/pull/6994)

### Tasks
- [x] Everyone to assigns himself to 2 - 3 issues, set a priority, report them on Kanban board before Wednesday, tries to present a solution/direction (at least 1 issue per person per week)
- [x] Add new rule to Contributor Guideline -> mention Core Team Member in ready to be merged PR comment as a reminder
- [x] When a PR is ready to be reviewed, ask reviewer for a check. You can do that adding his/her name in a comment on Github

## 28.04.2021

### Agenda

- [x] Review of [project board ](https://github.com/django-cms/django-cms/projects/5)

### Notes
- decision to mention core team member in the comment section of PR that is ready to be merged -> needs to be added to work group guideline -> added to task list

### Tasks

## 21.04.2021

### Agenda

- [x] Review of [project board ](https://github.com/django-cms/django-cms/projects/5)

### Tasks
- [x] Francesco to create clear instructions on how to manage Issues/Pr and to use the Kanban project board.

## 14.04.2021

### Agenda

- [x] To define Sr Rev and "Merger" groups
- Issue / PR Review: Reviews PRs
- Core Team: Consists of Senior Reviewers and can merge PRs
- [x] ~~Proposal: merge the approved issues/PRs between this meeting and Tech meeting~~
* ~~so to have a possibility to warn this Workgroup and~~
* ~~prevent to postpone everything to the next call in case of problems~~
- [x] What critera to filter issues before assigning them:
* from the newest to the oldest or
* ~~[this one](https://github.com/django-cms/django-cms/issues?q=is%3Aopen+is%3Aissue+milestone%3A%22DCA+Contribution%22) or what? (Of course we have to exclude every issues related to v.4 and Django 3.2)~~

- [x] [Another project for Django 3.2 compatibility?](https://django-cmsworkspace.slack.com/archives/C01NLLLTD7F/p1618360033000800)
* Another call for it? NO
* another Kanban table? A milestone
- [x] List of assigned issues and their status. All issues will be reported on Kanban scehma ([ Issue / PR work group ](https://github.com/django-cms/django-cms/projects/5)) by Francesco (all)

**Kanban's rule : max 15 issues in each "todo"/"in progress" columns at time**
| Reviewer | N. issue | N. PR | Status | Comments|
| -------- | -------- | -------- | ------ | ----- |
| | | | | |
- [x] Review of issues assigned (all):
* Problems?
* Relevant things to tell?
*
- [x] List of issue /PR approved and/or to merge
| N. issue | N. PR | status |
| -------- | -------- | ------ |
| 7001 | | done|
| 7003 | | asked questions to the author of issue |

### Tasks
- [x] Everyone
1. assigns himself to 2 - 3 issues
2. set a priority
3. report them on the aforementioned list before Wednesday
4. tries to present a solution/direction (at least 1 issue per person per week)

## 07.04.2021

### Agenda
- [x] Presentation of Francesco's process proposal
- [x] Creation of priority labels (low, mid and high)

### Tasks
- [x] Give work group members access permissions (labels, review etc.)(Nicolai)
- [x] Setup ongoing weekly 45 minutes Github Issues Call (Nicolai)