---
# System prepended metadata

title: Legoland Code Review
tags: [magesmiths]

---

---

tags: magesmiths
---

# Legoland Code Review


https://github.com/HausDAO/daohaus-app/pull/1374/files

///

modal overhaul:
https://github.com/HausDAO/daohaus-app/tree/modalOverhaul

more minion safe:
https://github.com/HausDAO/daohaus-app/pull/1392
- conditional input

https://github.com/HausDAO/daohaus-app/pull/1400
- simple form

https://github.com/HausDAO/daohaus-app/pull/1398


### 9/29

- app sweep to look for old modals

JORD:
look more into the minion safe hard mode pr:
formBuilder update on that toggle:
https://github.com/HausDAO/daohaus-app/pull/1398/files#diff-293125d3779aa6123a995960ea5fb8196e863b71f28daec0de9c823838afea8dR245


#### minion safe hard mode refactor

- conditionalTx
- remove the formBuilder extra logic




### 9/28

delete valueInput.jsx


### 9/22

made it to:
src/formBuilder/discourseMeta.jsx


signer.js
- use new form footer

proposalTypes.js
- see daotodao proposal types - we need to refactor all of that section
- needs form builder


general
- look at how we're fetching and storing vault data
    - ensure it matches the other metadata pattern - in session storage?
    - why is does the vault page fetch it each time
    - SAM


polls.js tests.js and pollService.js
- clean out the old stuff

lego organization
- nice to have
- can break legos into separate files and have a single file that imports and spit out a single object for all the places that need it

### 9/14 

made it to:
src/components/signer.jsx


add new progress indicator to all forms


medium level dev:
look into using error handling pattern across many api calls
https://github.com/HausDAO/daohaus-app/pull/1374/files#diff-ba22486284a2d11ec09bce3a0acc65ede3032fabe453b84cb51e3e29b573b568R76
and
https://github.com/HausDAO/daohaus-app/pull/1374/files#diff-3859fbb402cc453d3a71bbb434673cc2e1817042450dd9d1859e6a8521dcc432R474


NEW DEV CHALLENGE:
make a helper-

  const canInteract =
    daoConnectedAndSameChain(address, injectedChain?.chainId, daochain) &&
    +daoMember?.shares > 0;
    
 then search and replace daoConnectedAndSameChain
    
    
proposal actions/minion execute need a major refactor as part of proposal card updates


alignment issues
![](https://i.imgur.com/qW2VQtB.png)
![](https://i.imgur.com/zSkxHhV.png)


import orders
- andy cr?


Add rage kick to guildkick proposal details



