--- title: Triage meeting DATE tags: triage-meeting --- # T-lang meeting agenda * Meeting date: DATE ## Attendance * Team members: * Others: ## Meeting roles * Action item scribe: * Note-taker: ## Scheduled meetings - "Structural equality" [lang-team#94](https://github.com/rust-lang/lang-team/issues/94) - "Never allow unwinding from Drop impls" [lang-team#97](https://github.com/rust-lang/lang-team/issues/97) - "Dyn upcasting, safety considerations" [lang-team#119](https://github.com/rust-lang/lang-team/issues/119) - "Const eval overview" [lang-team#131](https://github.com/rust-lang/lang-team/issues/131) - "Lint policy" [lang-team#132](https://github.com/rust-lang/lang-team/issues/132) - ""RPITIDT"" [lang-team#144](https://github.com/rust-lang/lang-team/issues/144) ## Announcements or custom items (Meeting attendees, feel free to add items here!) ## Action item review * [Action items list](https://hackmd.io/gstfhtXYTHa3Jv-P_2RK7A) ## Pending lang team project proposals ### "Deprecate target_vendor " lang-team#102 **Link:** https://github.com/rust-lang/lang-team/issues/102 ### "Support platforms with size_t != uintptr_t" lang-team#125 **Link:** https://github.com/rust-lang/lang-team/issues/125 ### "Positional Associated Types" lang-team#126 **Link:** https://github.com/rust-lang/lang-team/issues/126 ### "Interoperability With C++ Destruction Order" lang-team#135 **Link:** https://github.com/rust-lang/lang-team/issues/135 ### "inner crates, aka multiple crates per file" lang-team#139 **Link:** https://github.com/rust-lang/lang-team/issues/139 ### "allow construction of non-exhaustive structs when using functional update syntax" lang-team#143 **Link:** https://github.com/rust-lang/lang-team/issues/143 ### "Add #[deprecated_safe] attribute to allow functions be be marked unsafe in a backwards compatible fashion" lang-team#147 **Link:** https://github.com/rust-lang/lang-team/issues/147 ### "TRIAGEBOT TESTING: Please ignore (rename 3)" lang-team#148 **Link:** https://github.com/rust-lang/lang-team/issues/148 ### "Async fns in traits" lang-team#150 **Link:** https://github.com/rust-lang/lang-team/issues/150 ### "extern macro!(ABI) fn" lang-team#151 **Link:** https://github.com/rust-lang/lang-team/issues/151 ## PRs on the lang-team repo None. ## RFCs waiting to be merged None. ## Proposed FCPs **Check your boxes!** ### "New Rust attribute to support embedding debugger visualizers" rfcs#3191 - **Link:** https://github.com/rust-lang/rfcs/pull/3191 - [**Tracking Comment**](https://github.com/rust-lang/rfcs/pull/3191#issuecomment-1064452047): > Team member @wesleywiser has proposed to merge this. The next step is review by the rest of the tagged team members: > > * [ ] @Aaron1011 > * [x] @cjgillot > * [x] @cramertj > * [x] @davidtwco > * [x] @eddyb > * [x] @estebank > * [x] @joshtriplett > * [ ] @lcnr > * [ ] @matthewjasper > * [x] @michaelwoerister > * [ ] @nagisa > * [x] @nikomatsakis > * [x] @oli-obk > * [x] @petrochenkov > * [x] @pnkfelix > * [x] @scottmcm > * [x] @wesleywiser > > No concerns currently listed. > > Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! > > See [this document](https://github.com/rust-lang/rfcbot-rs/blob/master/README.md) for info about what commands tagged team members can give me. - [**Initiating Comment**](https://github.com/rust-lang/rfcs/pull/3191#issuecomment-1064452035): > Thanks @ridwanabdillahi for your work on this RFC! > > I think we've achieved reasonable consensus from participants in this RFC for this to move forward. While we can continue to discuss the exact name of the attribute, I don't think that needs to block starting an > > @rfcbot merge ### "Allow using `for<'a>` syntax when declaring closures" rfcs#3216 - **Link:** https://github.com/rust-lang/rfcs/pull/3216 - [**Tracking Comment**](https://github.com/rust-lang/rfcs/pull/3216#issuecomment-1064213248): > Team member @nikomatsakis has proposed to merge this. The next step is review by the rest of the tagged team members: > > * [x] @cramertj > * [x] @joshtriplett > * [x] @nikomatsakis > * [x] @pnkfelix > * [ ] @scottmcm > > Concerns: > > * add-third-alternative (https://github.com/rust-lang/rfcs/pull/3216#issuecomment-1064214419) > * grammatical-ambiguities (https://github.com/rust-lang/rfcs/pull/3216#issuecomment-1064215076) > * ~~ultimate-syntax~~ resolved by https://github.com/rust-lang/rfcs/pull/3216#issuecomment-1068270337 > > Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! > > See [this document](https://github.com/rust-lang/rfcbot-rs/blob/master/README.md) for info about what commands tagged team members can give me. - [**Initiating Comment**](https://github.com/rust-lang/rfcs/pull/3216#issuecomment-1064213230): > @rfcbot fcp merge > > I'm in favor of making it possible to annotate closure argument types more explicitly. This seems like an obvious step forward and the one I would most expect. I'm going to move to FCP, though I do have a few concerns that I will log and would like to see discussed. ### "Tracking Issue for const offset_from (const_ptr_offset_from)" rust#92980 - **Link:** https://github.com/rust-lang/rust/issues/92980 - [**Tracking Comment**](https://github.com/rust-lang/rust/issues/92980#issuecomment-1065659273): > Team member @scottmcm has proposed to merge this. The next step is review by the rest of the tagged team members: > > * [x] @Amanieu > * [ ] @BurntSushi > * [x] @cramertj > * [x] @dtolnay > * [x] @joshtriplett > * [x] @m-ou-se > * [ ] @nikomatsakis > * [ ] @pnkfelix > * [x] @scottmcm > * [ ] @yaahc > > No concerns currently listed. > > Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! > > See [this document](https://github.com/rust-lang/rfcbot-rs/blob/master/README.md) for info about what commands tagged team members can give me. - [**Initiating Comment**](https://github.com/rust-lang/rust/issues/92980#issuecomment-1065659256): > Both teams sounds reasonable, yeah. > > Teams, do we want to allow offset-between-pointers calculations in `const`? > > Stabilization report from Ralf: https://github.com/rust-lang/rust/issues/92980#issuecomment-1065644848 > > @rfcbot fcp merge > > One correction to the report: it's `T: Sized` only, due to a where clause: > > https://github.com/rust-lang/rust/blob/335ffbfa547df94ac236f5c56130cecf99c8d82b/library/core/src/ptr/const_ptr.rs#L441-L452 > ### "Stabilize `let else`" rust#93628 - **Link:** https://github.com/rust-lang/rust/pull/93628 - [**Tracking Comment**](https://github.com/rust-lang/rust/pull/93628#issuecomment-1029383585): > Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: > > * [x] @cramertj > * [x] @joshtriplett > * [x] @nikomatsakis > * [x] @pnkfelix > * [ ] @scottmcm > > Concerns: > > * need-consistency-rvalue-temporary-rules-between-let-and-let-else (https://github.com/rust-lang/rust/pull/93628#issuecomment-1055738523) > * ~~not-while-rustfmt-breaks-on-it~~ resolved by https://github.com/rust-lang/rust/pull/93628#issuecomment-1032936704 > * ~~semicolon~~ resolved by https://github.com/rust-lang/rust/pull/93628#issuecomment-1059799661 > * ~~stabilization-report~~ resolved by https://github.com/rust-lang/rust/pull/93628#issuecomment-1033846359 > * ~~summarize-concerns~~ resolved by https://github.com/rust-lang/rust/pull/93628#issuecomment-1056785904 > > Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! > > See [this document](https://github.com/rust-lang/rfcbot-rs/blob/master/README.md) for info about what commands tagged team members can give me. - [**Initiating Comment**](https://github.com/rust-lang/rust/pull/93628#issuecomment-1029383577): > Shall we stabilize `let else` syntax? We've had many demonstrated uses, including extensively throughout `rust-lang/rust`, we've seen the value of it, and there aren't any known issues with it. > > @rfcbot merge ### "Stabilize `let_chains` in Rust 1.62.0" rust#94927 - **Link:** https://github.com/rust-lang/rust/pull/94927 - [**Tracking Comment**](https://github.com/rust-lang/rust/pull/94927#issuecomment-1067658436): > Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: > > * [x] @cramertj > * [x] @joshtriplett > * [x] @nikomatsakis > * [ ] @pnkfelix > * [ ] @scottmcm > > Concerns: > > * add-test-to-confirm-no-let-else-in-let-chain (https://github.com/rust-lang/rust/pull/94927#issuecomment-1068267198) > * doc-pr (https://github.com/rust-lang/rust/pull/94927#issuecomment-1068120114) > * irrefutable-lint (https://github.com/rust-lang/rust/pull/94927#issuecomment-1067658430) > > Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! > > See [this document](https://github.com/rust-lang/rfcbot-rs/blob/master/README.md) for info about what commands tagged team members can give me. - [**Initiating Comment**](https://github.com/rust-lang/rust/pull/94927#issuecomment-1067658430): > @rust-lang/lang, shall we stabilize let chains? > > @rfcbot merge > > @rfcbot concern irrefutable-lint ## Active FCPs ### "Add the partial-closure-args RFC." rfcs#2956 **Link:** https://github.com/rust-lang/rfcs/pull/2956 ### "Allow struct and enum to contain inner attrs" rust#84414 **Link:** https://github.com/rust-lang/rust/pull/84414 ### "Lazy tait take two" rust#94081 **Link:** https://github.com/rust-lang/rust/pull/94081 ### "Fix constants not getting dropped if part of a diverging expression" rust#94775 **Link:** https://github.com/rust-lang/rust/pull/94775 ### "Deprecate target_vendor " lang-team#102 **Link:** https://github.com/rust-lang/lang-team/issues/102 ### "Positional Associated Types" lang-team#126 **Link:** https://github.com/rust-lang/lang-team/issues/126 ### "Interoperability With C++ Destruction Order" lang-team#135 **Link:** https://github.com/rust-lang/lang-team/issues/135 ### "Add #[deprecated_safe] attribute to allow functions be be marked unsafe in a backwards compatible fashion" lang-team#147 **Link:** https://github.com/rust-lang/lang-team/issues/147 ### "Async fns in traits" lang-team#150 **Link:** https://github.com/rust-lang/lang-team/issues/150 ### "extern macro!(ABI) fn" lang-team#151 **Link:** https://github.com/rust-lang/lang-team/issues/151 ## P-critical issues None. ## Nominated RFCs, PRs and issues ### "Allow using `for<'a>` syntax when declaring closures" rfcs#3216 **Link:** https://github.com/rust-lang/rfcs/pull/3216 ### "Check if call return type is visibly uninhabited when building MIR" rust#93313 **Link:** https://github.com/rust-lang/rust/pull/93313 ### "Allow `impl Fn() -> impl Trait` in return position" rust#93582 **Link:** https://github.com/rust-lang/rust/pull/93582 ### "Stabilize `let_chains` in Rust 1.62.0" rust#94927 **Link:** https://github.com/rust-lang/rust/pull/94927 ### "Specify guarantees for repr(rust) structs" reference#1152 **Link:** https://github.com/rust-lang/reference/pull/1152 ### "Clarify guarantees provided by repr(packed)" reference#1163 **Link:** https://github.com/rust-lang/reference/pull/1163