Boa Monthly Sync - February 2025 === ###### tags: `Meeting` :::info - **Date:** 2025-02-25, 23:00 UTC - **Agenda** 1. ~~Welcome, Hans! `15min`~~ > [name=Jedel] 2. PR velocity a. coderabbitai? `15min` b. `dev` branch? > [name=Hans] 3. Temporal & Intl `20min` a. Progress update b. Future plans c. How do we want to handle Time Zones? > [name=Kevin] 4. Release artifacts `10min` a. Diff between Nightly vs. release > [name=Kevin] 5. Utility crates `10min` a. https://github.com/boa-dev/boa/pull/3849 > [name=Kevin] 6. Fate of boa_interop > [name=Hans] 7. Performance a. PR comments of V8 Benchmarks > [name=Hans] 8. Unsafe usage > [name=Kevin] - **Participants:** - Jedel (JDL) - Kevin (KN) - Hans (H) - Halid (HO) ::: ### Welcome, hans! Everyone: Welcome to the team! ### PR Velocity H: Proposes using code rabbit or a `dev` branch to increase speed. Is there potentially room in the budget? JDL: Is the AI particularly nitpicky on small PRs H: (Gives example of `coderabbit` on PRs) JDL: Another option that's obvious would be to reduce the number to one approval KDN: Might be worth looking into CODEOWNERs and only needing 1 review from a CODEOWNER JDL: We can move forward with 1 reviewer ### Temporal + Intl KN: Made a document detailing the current state of Temporal KN: https://hackmd.io/5zQk5zZPT0WmtA0kWIIN6g KN: 50% of tests are failing because of unimplemented features. KN: Some known bugs from `boa_tester`. KN: Feel free to take a look and test things. KN: Current main problem is timezone provider. Need to decide what to do with Windows and tzdb. ### Release artifacts KN: We publish binaries for releases but tars for nightly builds. Can we somehow unify both into a single release format? ### Boa interop H: Been a glue code to be able to use Boa in an easier way. H: I think it provides a lot of value, but it would be better to merge it into `boa_engine`. ### Performance H: Do we have a way to trigger benchmarks on PRs? JDL: Yeah, you need to add a label then push an empty change. Not ideal. JDL: I think it would be nicer to have a bot react to comments. KN: What about Bors? H: It seems to have an active forum. H: Oh it's just an archive from 2023 HO: I think it was deprecated. ### Action items - (JDL) Reduce the number of approvals per PR to one. Selectively require more if the PR gets too big to be reviewed by a single person. - (@hansl-) Look into using CODEOWNERS for the boa-dev repos. - (KN) Look into migrating the timezone provider to a ICU4X Data Provider. - (JDL) Try to extract parts of Intl into a separate crate. https://github.com/boa-dev/boa/issues/3712 - (HO) Look into unifying binary exports of published binaries and nightly tars. - (JDL) Try to extract utility crates for commonly used things from boa_engine. Create a `utils` subfolder for it and publish crates for them. (https://github.com/boa-dev/boa/issues/4182) - (HO) Try to repurpose the TaggedPtr PR to be a separate smaller crate instead of a `boa_utils` crate. - (@hansl-) Will start merging parts of `boa_interop` into `boa_engine` and start using the integration APIs into the codebase. - (OPEN) Look into why code coverage isn't commenting results. https://github.com/boa-dev/boa/issues/4180 - (OPEN) Look into being able to comment the test262 results from an external branch. https://github.com/boa-dev/boa/issues/4105 - (OPEN) Look into creating a bot to trigger benchmarks using a comment on a PR. https://github.com/boa-dev/boa/issues/4180 - (JDL) Audit unsafe blocks and determine if some of them could be safe. https://github.com/boa-dev/boa/issues/4181 - (ALL) Add documentation about when and when not to use `unsafe` for PRs (or something like that). - (OPEN) Add Miri CI for select crates (boa_gc, boa_string, maybe Nan boxing?) (https://github.com/boa-dev/boa/issues/2366) - (JDL) Schedule monthly call for Boa.