# MYR Developer Meeting Notes

_Notes of our summer meetings (Tue & Thu: 1-5pm)_
_Make sure to add your name and @ in Attendees and write the main topics discussed during the meeting_

## 08-25-2022

### Attendees:
- John Kelly @jf-kelly
- Ryan Maradiaga @RJMaradiaga
- Bryan Montalvan @bmontalv
- Nipun Kisari @nkisari

### Agenda and Notes:
- Mostly what is left is preparing the changes and bug fixes for the summer release
- Approving and merging PRs
- Group meeting with entire ECG
- Discussed plans moving forward, immersive scholars will be working on poster, all that is left is to get summer release ready and not start anything new yet
- Nipun submitted PR for welcome controls on a different branch

### Actions/To-dos:

<hr />

## 08-23-2022

### Attendees:
- John Kelly @jf-kelly
- Ryan Maradiaga @RJMaradiaga

### Agenda and Notes:
- Shared our updates with Fred and the rest of ECG
- We think we are essentially ready for a summer release
- Ryan will continue working on moving the about page into React
- John will be looking into the remaining issues to see what can be done before the summer release
- John added new feature that would allow users to submit scenes that could be used as example scenes
- Submitted PR for this

### Actions/To-dos:
- [ ] Create our summer release
- [ ] Review and approve all the outstanding PRs

<hr />

## 08-18-2022

### Attendees:
- John Kelly @jf-kelly
- Ryan Maradiaga @RJMaradiaga

### Agenda and Notes:
- Ryan is going to be working on moving the about page from the backend into the frontend using React
- John still working on fixing the user speed
- Submitted PR for the fix
- John also working on creating new example scenes
- New feature idea: better collision physics
- For example, two objects could collide with one another, but one can stay still. As of now, the only way for two objects to hit each other is if they are both 'pushable', but with this addition, one object could stay still but still interact with another object that is pushable
- Example of use: if the user wants to create a game, they could be able to push one object into a certain area by hitting it off of other objects that stay stationary (maybe like pinball)

### Actions/To-dos:

<hr />

## 08-16-2022

### Attendees:
- John Kelly @jf-kelly
- Ryan Maradiaga @RJMaradiaga
- Nipun Kisari @nkisari
### Agenda and Notes:
- Project board now has 9 issues left to do
- We will continue trying to finish these in the next couple weeks
- Nipun asked Bryan for admin login to have access to the database and add an example scene for the gltfmodel() function.
- John looking into adding example scenes to MYR
- John added a new issue that has to do with the light course glitching out
- Ryan created pull request for new spin feature that adds three new functions, one for each axis you can spin around
- John reviewed and approved this PR
- John has been working on the issue where if you exit VR mode while holding a movement button, it continues to move
- Tried adding a state that defined when VR was open, and then if it was not open, any key pressed would be negated, but this did not work
### Actions/To-dos:

<hr />

## 08-11-2022

### Attendees:
- John Kelly @jf-kelly
- Ryan Maradiaga @RJMaradiaga

### Agenda and Notes:
- Ryan currently working on feature that would allow a spin animation on the x- and z- axes as well as the y-axis
- Also within this feature: ability to choose the type of rotation (normal/alternate)
- John currently working on two issues: footer alignment and y-positioning
- Footer alignment: can't seem to find the issue that is causing it to be different, have tried changing the text alignment for the page as a whole, focusing in on the float property, yet so far nothing has yielded results
- Result: was able to fix the problem, PR updated with these new changes
- Y-positioning: there is a formula for where the object should be positioned based on how it is scaled in terms of y, yet I have been unable to implement this formula
- Result: was able to find a solution, the fix works for objects with flat bases only

### Actions/To-dos:
- [ ] Discuss next steps as we near the end of the summer
- [ ] Get all pending PRs reviewed/approved and ready for deployment

<hr />

## 08-09-2022

### Attendees:
- John Kelly @jf-kelly
- Ryan Maradiaga @RJMaradiaga
- Bryan Montalvan @bmontalv
- Nipun Kisari @nkisari

### Agenda and Notes:
- Currently working on fixing Ryan's dev environment
- Also going over our project board (approving PRs, looking into merge conflicts)
- John is currently working on resolving merge conflicts from previous PRs
- Autocomplete (reference search bar) is all set now
- Android Notification is also all set
- Ryan is all set with his dev environment now
- Footer still somewhat misaligned, John having trouble with the 'Privacy Policy' and 'Terms of Service' as I cannot get them to align to the left
- Tried changing the float value and the alignment value, no change
- Bryan suggested Nipun to use the inspector tool to see how to change the padding of the "Command Key" in the welcome screen

### Actions/To-dos:

<hr />

## 08-04-2022

### Attendees:
- John Kelly @jf-kelly
- Ryan Maradiaga @RJMaradiaga

### Agenda and Notes:
- Ryan still having issues with VS Code - his code is up to date with dev, yet when he runs it, it is not the same as dev
- Ryan working on changing the speed slider UI to have it make more sense to the user. Right now it goes from 0-1000. This number has no units, so instead of having that, the idea is to have the words "slow" and "fast" on the left and right of the slider to indicate speed instead of the arbitrary number.
- John created pull request that fixes issue causing bad interaction between setScale and groups
- John created another pull request for a feature that creates a hover effect when you have your mouse over a scene in the project view modal
- Discussed mobile view and how it should eventually be changed, because on certain phones, the website looks broken
- John created one more PR that fixes the alignment of items in the footer - however, the changes do not look exactly like they used to, so this could require further discussion
### Actions/To-dos:
- [x] Fix Ryan's code so that he can work on issues in dev
- [x] Continue to review PRs in the 'Needs Review' section of the MYR Development project board
- [x] Figure out spacing issues in the footer (issue in dev)
- [ ] Look into fixing the mobile view
<hr />

## 08-02-2022

### Attendees:
- John Kelly @jf-kelly

### Agenda and Notes:
- John talked about plans for the next two weeks (since Fred will be on vacation and not at the meetings)
- First priority = fixing issues
- John currently working on the bug where objects are not positioned on the ground when y is set to 0
- This happens when an object is made smaller, since the position is applied to the center of the object, not the bottom of it
- Not sure how to change this behavior
- New feature idea: onClick function that allows the user to change an attribute of an object by clicking it
- Brought up by a SoarCS student
- Figure out a formula for having objects positioned on the ground, but having trouble implementing it
- As far as I can tell, some of the issues seem somewhat complex: I have looked into the y-positioning bug and the UI/UX feature update of changing the hover effect for projects

### Actions/To-dos:
- [ ] Keep working on issues before moving on to new features
- [x] Figure out how to change the setYPos function so that it will use a formula

<hr />

## 07-28-2022

### Attendees:
- John Kelly @jf-kelly
- Bryan Montalvan
- Ryan Maradiaga

### Agenda and Notes:
- Bryan created new GitHub project
- Discussed current and future project ideas/bug fixes
- Ryan having an odd issue with his code: the code itself is up to date with dev (he did git fetch upstream, git pull upstream dev), yet when he runs the code, it does not look like dev
- Prevents him from working on the issue with the footer not being aligned
### Actions/To-dos:
- [x] Make sure project board is up to date
- [ ] Fix new issues

<hr/>

## 07-26-2022
No notes

<hr/>

## 07-21-2022

### Attendees:
- John Kelly @jf-kelly
- Bryan Montalvan @bmontalv

### Agenda and notes:
- John submitted PR for Scene title and description edit feature
- Issues possibly cause by a-frame and React dependency changes
- A-frame: could be causing issue with user speed
- React: could be causing issue with tour
- Should mainly focus on fixing issues rather than new features
- John has been looking into the issue with the items in the footer not aligning, fairly certain that it is a problem with bootstrap

### Actions/To-dos:
- [x] Look into dependency changes that could be causing the issues in dev
<hr />

## 07-19-2022

### Attendees:
- John Kelly @jf-kelly
- Bryan Montalvan @bmontalv

### Agenda and notes:
- John and Bryan went over styling issues with MYR (horizontal overflow and thick line).

### Actions/To-dos:
- [x] We need player movement speed to be fixed

<hr />

## 07-14-2022

### Attendees:
- John Kelly @jf-kelly
- Bryan Montalvan @bmontalv

### Agenda and notes:
- Jaelyn went over some of the security changes she wants
### Actions/To-dos:
- [x] Bryan go on DataBase and figure out how to give students access to the server
- [ ] Bryan, find solution to our Wiki
- [x] John, will submit a PR fixing the grid scale
<hr />

## 07-12-2022

### Attendees:
- John Kelly @jf-kelly
- Nipun Kisari @nkisari
- Ryan Maradiaga @RJMaradiaga
- Bryan Montalan @bmontalv

### Agenda and notes:
- First part of meeting:
- Fred went over the iSENSE AI project that will be taking place next week - same will be done for MYR team next week
- Second part:
- MYR team met and discussed what has been worked on and what we will be working on next
- Ryan submitted pull request for new features:
- Reset sky color
- Reset floor color
- Toggle cursor on/off
- Whole team will be looking at dev to see if anything broke with the new version being on there
- Nipun and Ryan looking to work with courses/adding new ones - still waiting on access to the database
- John will be looking into fixing merge conflicts with a previous PR, as well as working on possible new features
- For now, John will be tabling the feature of changing the title and description of a saved scene because not able to test it yet
- Work needs to be done on dev:
- Bar between editor and scene view is too thick
- The tour gets messed up with the two bottom buttons (keyboard shortcut, font size)
- Website is slightly too long horizontally now

**Issues:**
- Middle bar between editor and 3D space
- Creates x-scroll overflow on the website
- The `gltfModel()` method's example link is not working. (Links to previous model route, should not link to assetReference)
- Step 12 of tour not highlighting the keyboard shortcut button
- Fix grid (currently its not covering the scene floor)
- Default player speed is twice as fast
- Change the metrics of the speed slider so it makes more sense and is intuitive. (Potentially add slower and faster text)
- Fix the torus model (Using AFrame), currently our torus shape does not look like a torus.
- Update the example scenes
- Compile/Make example scenes

**Dicussed strides to making MYR more open-source friendly**
- Creating a new Developer docs page (outside of GitHub using maybe ESDocs)
- Creating a PR description format

- Bryan created Discord which will be open to all users

### Actions/To-dos:
- [x] John to test and finish scene title change feature
- [ ] Nipun to test updates to dev and find any issues on the site in general
- [x] Design Summer Developer t-shirt
- [ ] Create new issues
- [x] Work on the discord server

<hr/>

## 07-07-2022

(No-show meeting)

<hr/>

## 07-05-2022

### Attendees:
- Nipun Kisari @nkisari
- Ryan Maradiaga @RJMaradiaga
- David Jones-Martin @davidjonesma

### Agenda and Notes:
- Nipun assigned himself an issue
- updating Orient Yourself Course
- looked at how to improve other courses
- Ryan finishing up the social and behavioral courses

### Actions/To-dos:
- [x] Ryan to finish the social and behavioral research course

<hr/>

## 06-30-2022

### Attendees:
- John Kelly @jf-kelly
- Ryan Maradiaga @RJMaradiaga
- David Jones-Martin @davidjonesma

### Agenda and Notes:
- John working on fixing pull request for android notification feature
- Problem with the package lock and paackage.json files
- Updated PR with new commit, however, the checks are not running for some reason
- David is working on the about page
- Ask Bryan how to run express server.

### Actions/To-dos:

<hr>

## 06-28-2022

### Attendees:
- John Kelly @jf-kelly
- Ryan Maradiaga @RJMaradiaga
- Bryan Montalvan @bmontalv

### Agenda and Notes:
- Ryan is still working on redoing and separating previous pull request. The pull request for button visibility is finished. Now working on buttons for reseting scene colors and toggling cursor.
- John will be working on scene title and description changing feature
- John fully completed the CITI course
- Discussed which PRs will be pushed in version 3.2.0 and which will be held off until 4.0.0
- 3.2.0 will mainly be bug fixes and minor enhancements
- Goal is to potentially ship the redesign in version 4.0.0
- Issues with merge conflicts for a couple of PRs
- (Bryan) merged PRs into dev

### Actions/To-dos:
- [ ] Ryan to complete updateMenu pull request
- [x] Make sure version 3.2.0 is all set before code freeze (Fri 7-1-2022)

<hr>

## 06-23-2022

### Attendees:
- John Kelly @jf-kelly
- David Jones-Martin @davidjonesma
- Ryan Maradiaga @RJMaradiaga

### Agenda and Notes:
- John considering new feature where you can edit the title and description of a scene after it has already been saved
- John created two new pull requests for small changes - not urgent
- Ryan worked on one more module in the CITI course and then started button visibility again
- John started work on being able to change scene titles and descriptions, but unsure on how to test it

### Actions/To-dos:
- [x] John to work on new feature mentioned above
- [x] Ryan to redo buttonVisibility and menuUpdate changes and put them into two separate pull requests

<hr>

## 06-21-2022

### Attendees:
- John Kelly @jf-kelly
- David Jones-Martin @davidjonesma
- Ryan Maradiaga @RJMaradiaga
- Bryan Montalvan @bmontalv
- Lauren Seavey @lseavey

### Agenda and Notes:
- Talked about code freeze: not pushing anything major before the MYR summer camp and SoarCS
- Only fixing bugs
- Get last bug fixes in by next Friday (July 1st)
- Discussed taking a course on ethical research, should take about 15-20 hours
- Make it so that everyone can be involved in reviewing each others code (PRs)
- Dicussed idea of having a structured meeting time within the MYR work-together time-frame
- Dicussed **Summer Release** after the summer-course and program is over
- Will happen around August
- This will be a big release of all summer developers latest features and fixes
- Went over Git workflow, to prevent making changes to same branch

### Actions/To-dos:
- [x] Give each developer reviewer status (Bryan)
- [x] Potentially create a sub-group on the MYR org team similar MYR Leadership Org
- [ ] Give Nipun acccess to LearnMYR server and write doc sheet on how to access Database and make changes to DB (Bryan)
- [ ] Figure out which server the DB is hosted in (if not in all three) (Bryan)

<hr/>

## 06-16-2022

### Attendees:
- John Kelly @jf-kelly
- Ryan Maradiaga @RJMaradiaga
- Nipun Kisari @nkisari

### Agenda and Notes:
- I believe the problem with the reference examples has to do with the font size changes for whatever reason
- John fixed the reference example problem
- Created pull request
- Everyone working on individual projects
- Nipun continuing to modify the "Orient Yourself" course
- Ryan finished working on the reset sky color and reset floor color buttons, and is currently working on displaying the cursor
- An idea brought up is that maybe while hoovering over a pushable object, the cursor can change color.
- Although the idea of pushing an object is brought up in the "Working with Shapes" course, outside of that, there is no indication for if an object is pushable.
- With cursor toggle, when the page is refreshed, the cursor stays hidden

### Actions/To-dos:
- [x] Create new issues/ new features for people to work on
- [ ] Add different cursor colors based on if hoovering over a pushable object (?)
- [ ] Despawn pushable objects after certain limit to prevent performance issues, especially on chromebooks

<hr>

## 06-14-2022

### Attendees:
- John Kelly @jf-kelly
- David Jones-Martin @davidjonesma
- Ryan Maradiaga @RJMaradiaga
- Nipun Kisari @nkisari

### Agenda and Notes:
- Got Nipun set up with the backend, and he added himself to the team page
- Also created a pull request for this
- Ryan is working on creating multiple buttons in the settings to reset the sky color, reset floor color, and to toggle the cursor
- Everyone is now completely set up with their developer environments
- Created pull request for Ryan's progress bar feature
- Nipun created pull request for both the welcome screen changes, and within the same pull request, a change where the support button brings you to the support page rather than opening your email
- New bug: reference examples no longer work (John looking into this)

### Actions/To-dos:
- [ ] John and David to update Wiki on getting dev environment set up
- [x] Fix bug with reference examples
- [ ] Nipun to create a tutorial/course on player movement

<hr>

## 06-09-2022

### Attendees:
- John Kelly @jf-kelly
- Ryan Maradiaga @RJMaradiaga
- Jaelyn Dones @jdones01
- Bryan Montalvan @bmontalv
- Lauren Seavey @lseavey617
- David Jones-Martin @davidjonesma
- Nipun Kisari @nkisari

### Agenda and Notes:
- **Dicussed integration of Netlify**
- [Netlify](https://docs.netlify.com/) is a tool for previewing changes to a web app. (Creates a static deployment)
- **John's Grid fix demo**
- John gave a demo previously broken grid
- PR Link: https://github.com/engaging-computing/MYR/pull/578/files
- **MYR Afterschool (Summer Session July)**
- Look over revised study materials
- Review changes of 504
- **David gave demo of his copy keyboard shortcut feature**
- Needs to add keyboard shortcut to keyboard shortcut menu. Feature has been made via making changes to Ace Editor
- **Jaelyn and Bryan won't be able to work on major features during the summer (work and classes)**
- **John added two new parts to the tour on MYR, one for the keyboard shortcuts button and one for the font size button.**
- Worth doing?
### Actions/To-dos:
- [x] New Members add yourself to Team page
- [ ] Ryan, Nipun, David finish their issues
- [ ] Dicuss issues next meeting

<hr>

## 06-07-2022

### Attendees:
- John Kelly @jf-kelly
- Ryan Maradiaga @RJMaradiaga
- David Jones-Martin @davidjonesma
- Bryan Montalvan @bmontalv
- Nipun Kisari

### Agenda and Notes:
- David installing new npm package to be able to implement keyboard copying feature
- Nipun is deleting and reinstalling VS Code to hopefully be able to run npm install
- Ryan creating mockup for Bryan in reference to his button change pull request
- In larger ECG Meeting: everyone got up to date on what projects they have been working on
- Assigned Ryan to work on course progress bar addition
- Nipun all set with front-end dev environment; now needs to finish getting set with back-end
- John opened new issue: setting the position of an object does not align with grid lines
- Update: made pull request, pending approval

### Actions/To-dos:
- [x] Fix new bug that John created issue for (John working on this)
- [x] Get Nipun's back-end up and running
- [x] Ryan to finish course progress bar - very close to being done

<hr> <!-- This is a horizontal line to seperate meeting days -->

## 06-02-2022

### Attendees:
- John Kelly @jf-kelly
- Ryan Maradiaga @RJMaradiaga
- Nipun Kisari @nkisari
- David Jones-Martin @davidjonesma

### Agenda and Notes:
- Ryan created pull request which increased visibility of font and keyboard shortcuts buttons
- He also found a bug with the support button: something to look into
- John added screenshot to team page update pull request
- Nipun still has issues installing node_modules package
- Have tried many different solutions, just not able to run npm install
- End of meeting: John spent the day mostly helping Nipun get set up, Ryan worked on button visibility, going forward we would like to start assigning more issues to Ryan and Nipun to get them more acquainted with the system

### Actions/To-dos:
- [x] Figure out how to fix the issue with Nipun's dev environment

<hr> <!-- This is a horizontal line to seperate meeting days -->

## 05-31-2022

### Attendees:
- Bryan Montalvan @bmontalv
- John Kelly @jf-kelly
- Ryan Maradiaga @RJMaradiaga
- Nipun Kisari @nkisari
- David Jones-Martin @davidjonesma

### Agenda and Notes:
- **Go over David's Wiki Changes**
- David work with John to revise **Install MYR** wiki page
- **Plans for the summer**
- Increase communication on Slack, it doesn't have to be MYR specific
- **Ideas for features**
- Add more models (John)
- Add more GLTFs model to assetReference
- Add more courses with more CS concepts
- Saving progress done in courses, potentially add progress bar. (Ryan)
- Make player movement more apparent (whether by course or by showing in welcome screen) (Ryan)
- Add editor shortcut for copying a line (ctrl + c) similar to VS Code
- Team pages:
- Ryan, Nipun, and David add yourselves to Team Page. (Do this in a pair with older members)
- Link to HTML: https://github.com/engaging-computing/MYR-backend/blob/master/public/about/team/index.html
Command for starting docker daemon```shell sudo systemctl start docker```
- Create either a button to make grid more transparent or create a bar that changes the transparency
- **Bug Fixes**
- **Bug** Whenever a user uses WASD first and then uses their mouse there is a bit of delay. (Only on trackpads)(Nipun)
- **Hand out assignments/projects to Ryan, Nipun, and David**
- First @bmontalv will create issues from features & bug fixes noted and then Ryan, Nipun, and David will select which they would like to work on. And this includes older issues

### Actions/To-dos:
- [x] Finish onboarding Ryan and Nipun to MYR's dev environment (backend)
- [x] John to send Bryan screenshot of changes done to Team Page
- [x] Ryan, Nipun, and David make PR's to add yourselves to team page
- [x] @bmontalv create issues from dicussed features and bugs
- [x] @RJMaradiaga @nkisari @davidjonesma choose from newly created issues