# 6.12.24 - [Hafsa Branch](https://github.com/Hafsa-Naeem/pkp-lib/tree/i10637_add_canLoginAs_canMergeUsers_to_users_endpoint) - https://github.com/pkp/pkp-lib/pull/10658 - Status of the review and branch - https://docs.google.com/document/d/1tJLPuFS9fsVXvovtOaSNlH3SjBRJLA4Y4s9_CvnWhHI/edit?tab=t.0 # 22.11.24 - Ein Blog - # 29.10.24 - Are there anything to the - Dulip: write Erik - # 21.10.24 - https://github.com/pkp/pkp-lib/pull/10536 - # 16.10.24 - what is left in the PR - usersTable - # 25.9.26 - editing the personal information - 12 moify invitation when change - cancel email : there should be a clear message. - accept invitation - ui-library -as soon, when he can review that ? # 19.9.2024 - ui-library - Dulip : todo - major problems - automatically logout is not always working - - - https://github.com/craft-oa/gdpr-invitation/issues/assigned/ipula - Server - [9659](https://github.com/pkp/pkp-lib/issues/9659) - Find out what are the missing components Meeting with jarda - Orcid Appointment - Dimitris plans # 13.9.2024 - validation issues #9658 - Multilingual server - buttons are a problem. - firefox - Dulip mattermost dev chanel: i8ncontroller http://localhost/ojs/index.php/publicknowledge/api/v1/_i18n/ui.js?hash=f47e87ba5e915cf9fadba36d4623ced14761bdf0 - Devika: User loggged in , # 4.9.2024 - https://github.com/craft-oa/gdpr-invitation/issues/22 - https://github.com/craft-oa/gdpr-invitation/issues/21 - https://github.com/craft-oa/gdpr-invitation/issues/15 - Create new user is working - Ipula.Update the server with current changes - Dulip:Ask Devika to mockup the error message, imge - Dulip: ask Alec to immediatly check the API - Ipula: cancel inviation - Dullip: Revew code - Dulip: Next week meeting for Orcid - # 23.08.2024 - edit form (agreed ) - validation - protocls to follow - Jarda, ipula: any mandatory field has to be validated, whether it is sent or not - Dimtirs: Only sent fields are validated - Dulip - meeting - csrf token issue - # 20.8.2024 - What has to be now - Multilingual forms are not working - issues with the vue-js - view invitation - Invite table user yet to accept should be readable - Visual additions - Date validation in server - Orcid verification has to be created - csrf-token - new user cannot accept invitation https://github.com/pkp/pkp-lib/issues/10311 - - We can # 26.7.2024 1. For an existing user: video - invitation, how click this email and after that how it looks like in the user. 2. 3. For new user: Video - Server installation - EmptySection - Default color inside form has to be checked. (backgound is white in storybook, ojs color change in in discussion) - - PR : 9658-api (ask Dimtirs to have a look) , - we have followed the available patters (review) - invitation-landing-page (Jarda has already reviewed) - Dimitris - Dulip: Appointment, - https://nextcloud.publicknowledgeproject.org/s/4d9bjweH6j84WNC - email composing change - Devika's email - Notifications - Remove roles - automatically removed. - Creating the landing page - Accept invitation page, decline invitation page - We will use the OJS - **OJS: add that functionality to the OJS** - Show the dialog - Invitations page - roles removal accept, styling related tasks - We can cancel next meeting - Vitaliy will be # 2.7.2024 - [ ] Dulip: Ask Devika about the generic message - [ ] 11.07. Next friday, # 26.6.24 Ipula, Dimitris, Alec, Dulip, Jarda - [ ] Validation is different - [ ] refine should be roles - [x] database user and password is ok to be saved in the - [x] country list should be filled - [x] Password should be non-text - [ ] Refining the mismatches - [ ] Dimitris will work on the first business-logiv. - [ ] Deadline to implemnt. End of September. # 14.6.24 -- - [x] Create user invitation - [x] Accept user invitation - [ ] Marc Bria get involved in reviewing - [ ] Dimitris call at the end of the week. 17.06.2024 - [ ] API decsription - [ ] Add all the issues and finish the ui - [ ] Holidays - [ ] Check with Marco - [ ] ## 26.06.24 - invitations api - - invitation payload - - Roles and end-dates - When you are accepting the invitation ad for how long - Username password saving (only for new user invivation) - Orcid-roles (orcidId, accessToken ..) - The way hanlders should be written (Business-logic) - Authorize - jobs: is there a recommended way or an example ? - Create user (who is going to do) - At least once in month ## 10.6.24 - laravel validation pattern - - End-point ```jsonld! { "orcid": "https://orcid.org/0000-0002-1212-4794", "orcidAccessExpiresOn": "2041-06-21T06:13:06Z", "orcidAccessScope": "/activities/update", "orcidAccessToken": "1231-1d2fa4f043e42046b", "orcidRefreshToken": "de90dasda938a-d9b993394fd6", "orcidWorkPutCode": 98361139 } ``` ## 07.6.24 - [Current Tasks](https://docs.google.com/spreadsheets/d/1utPLmLnTBrOJbKM6K3bO1V9y58WrMhaPtV7L7l5qz9s/edit#gid=0) - Accept invitaion (next Button) - Testing Dimitris Implementations and Feedback - ## 24.5.24 - Status - validation - Jarda will look into it. - Dulip Away 05.Aug- 16.Aug - Erik to - ui-library - ## 21.5.2024 - POST one endpoint to create an inviation. it returns only the id - PUT for update the payload ## TODO - review merging the changes - Ipula: error handlind in vuejs for different steps - create the logic - userinviationPage one store - being able to remove the code - Dulip: Devika the way errors are displayed - Devika and Jarda will work there. - - check the api and - Orgainizatoin - PRs - https://github.com/pkp/ui-library/pull/310 - https://github.com/pkp/ojs/pulls/ipula - can we cloe anything here ? - https://github.com/ipula/ojs/tree/9658-user-api - Understanding questions ? https://github.com/jardakotesovec/ui-library/tree/invitation_structure - Invitation payload updated ,when it is updated - Component ? - Accept invitation ### can we break-down the steps in [#9658](https://github.com/pkp/pkp-lib/issues/9658) #### Some ideas to look at what is missing and where we are waiting ? - A. Landing Page ( Settings > Users & Roles > Users) | Step| Title | API Support | UI- Support PKP | UI- Support TIB | in PR | in Branch | Remarks | To be reviewed | Related | | --- | --- | --- | ---- | ---- | ---- |---- | ---- |---- | ---- | | 1 * | | Waiting for Dimitris | Review required | Finished [310](https://github.com/pkp/ui-library/pull/310) | | [ipula-inviation](https://github.com/ipula/ui-library/tree/invitation) | Storybooks has to be done , mostly the focus is on storybook| Jarda| | | 2 |Drop-down , when more options clicked on invitations table | | Waiting for Jarda to create the component| Add the URL links | [310](https://github.com/pkp/ui-library/pull/310) | [ipula-inviation](https://github.com/ipula/ui-library/tree/invitation) | on hold | | | | 3 |Drop-down , when more options clicked on users table | | Waiting for Jarda to create the component | No changes necessary | | | | | | - B. The JM/editor needs to add a new role to a known user and searches for the user via their username or email ID by clicking on “invite user to take a role | Step| Title | API Support | UI- Support PKP | UI- Support TIB | in PR | in Branch | Remarks | To be reviewed | Related | | --- | --- | --- | ---- | ---- | ---- |---- | ---- |---- | ---- | | 1 * | | Basic support from Dimtris | Review | Finished| [310](https://github.com/pkp/ui-library/pull/310) | [ipula-inviation](https://github.com/ipula/ui-library/tree/invitation) | Changes requested, Business-logic has to be added after Dimitirs work | Jarda| ||| | 2 * | | UPload payload support needed | Review | Finished| [310](https://github.com/pkp/ui-library/pull/310) | [ipula-inviation](https://github.com/ipula/ui-library/tree/invitation) |**Remove roles has to be discussed** Bozana and waiting for Answer | Jarda| | | 3 |Email | :ok: | Review |Finished |[310](https://github.com/pkp/ui-library/pull/310) | [ipula-inviation](https://github.com/ipula/ui-library/tree/invitation) | | Jarda||**Remove roles has to be discussed** Bozana and waiting for Answer | Jarda| | | 4 | Inviation sent | :ok: | Review |Finished |[310](https://github.com/pkp/ui-library/pull/310) | [ipula-inviation](https://github.com/ipula/ui-library/tree/invitation) |Design should match Devikas design :x: | Jarda| | 5 |Email send function | [PR](https://github.com/pkp/pkp-lib/pull/9852/files#diff-8d0a3cf0b5d23de0415578850c17c9c396d776a64a8f1c853fc552479960e6f9)| not required | not required | | | Alec to review| | 6 | User accepting the inviation | :ok: | Review |Finished |[310](https://github.com/pkp/ui-library/pull/310) | [ipula-inviation](https://github.com/ipula/ui-library/tree/invitation) |Design should match Devikas design, The message should be changed :x: | Jarda| - C. The JM/editor needs to add a new role to a known user and finds the user in the list or searches for the user via their username or email ID | Step | API Support | UI- upport-PKP | UI- Support TIG | in PR | in Branch | Remarks | To be reviewed | Releated | | --- | --- | ---- | ---- | ---- | ---- |---- | ----| ----| | 1 |Same component as B1 | | | | | | 2 | Same component as B2 | | | | | | 3 | Same component as B3| | | | Jarda will add a selection message, Ipula will have a look into why search function is not working in ui-library, Jarda will redesign , language selection component| | 4 |Same component as B4 | | | | | | 5 |Same component as B5 | | | | | | 6 | Verify ORCiD | Review |Finished |[358](https://github.com/pkp/ui-library/pull/358) | [ipula-accept-invitation](https://github.com/ipula/ui-library/tree/invitation) | Ipula : clarify if it should be css | Jarda| | 7 | A link to the orcid validation has to be done| Review |Finished |[358](https://github.com/pkp/ui-library/pull/358) | [ipula-accept-invitation]((https://github.com/ipula/ui-library/tree/invitation)) |:x: ORCid to be discussed| Jarda has to review the table| | 8 | TODO | | | | | | 9 | Same component as C3 | | | | | | 10 |TODO | | | | | issue9658-C1 - D. The JM/editor needs to add a new role to a known user and finds the user in the list or searches for the user via their username or email ID. | Step | API Support | UI- Support | in PR | in Branch | Remarks | To be reviewed | Related| | --- | --- | ---- | ---- | ---- | ---- | ---- | ----| | 1 | Same as B1| | | | | | 2 |Same as B2 | | | | | | 3 | Same as C3 | | | | | | 4 | Same as C4| | | | | | 5 | Same as C5 | | | | | | 6 a New implmentation Finished |[358](https://github.com/pkp/ui-library/pull/358) | | | | | Jarda| | 6 b | 6a with an error message| | | | | Check with Jarda and Devika for error message component or css-class | | 7 |Orcid-Link has to be added very similat to C6| | | | | | 8 | TODO: Visual-component: | | | | | | Dulip: makes sure the author data is available to form. Erik+Ipula Mattermost conversation | | 9 |Review (without verification) |Finished |[358](https://github.com/pkp/ui-library/pull/358) | | | | | 10 | Review |Finished |[358](https://github.com/pkp/ui-library/pull/358) | | | |TODO| || || || || || || # We have to do - E. For Multiple Hosted Journals, Editors/ JMs cannot access information of users of one Journal to another. In spite of the journals being hosted on the same OJS instance, the user will have to go through the verification again to protect their information and fort he process to be GDPR compliant. This is the same method followed by likes of Slack wherein even if the channel is hosted by the same company, the invitation process needs to be followed and accepted by the user. However, I as a user will not have to create a new account, I can use my existing OJS logins and verify and accept the role | Step | API Support | UI- Support | in PR | in Branch | Remarks | To be reviewed | Related | | --- | --- | ---- | ---- | ---- | ---- | ---- | ----| | 1 | | | | | | | 2 | | | | | | | 3 | | | | | | | 4 | | | | | | | 5 | | | | | | | 6 | | | | | | | 7 | | | | | | | 8 | | | | | | | 9 | | | | | | | 10 | | | | | | ## 14.5.2044 - jatsTemplate - TIB, TSV meeting ask antti-jssi , where to write and how etc. - ## 11.5.24 - GDPR confirmation for [#9660](https://github.com/pkp/pkp-lib/issues/9660) - All UI components of the [#9658](https://github.com/pkp/pkp-lib/issues/9658) are ready. - Link : https://hackmd.io/3i2cLpyESra8agL_UQFL5g # 2024 07.05.2024 - Update - #9658 - Multiple journal installation - user accept inviation - Double orcid verficiation avoid - Users details are used for journal A - can be complications, because the user did not give approval for this. - User profile - Change email invitation - PKP will take care of that - ORCid - - After invitation roles are removed: old inviation get deleted and a new inviation is sent with the correct details - uploadpayload endpoint in this case - UI Details View Dateils page - TODO - Dulip: summarize in the next two eeks - Install developments - Summarize the GDPR requirement for 9660 - - invitations - Users in subfolder - - Jarda will talk with the team and lets know. - mswjs.io - June - Organization ## 30.4.2023 - Review #9658 development - What is missing ? - Do we need help ? - - For user orcid Icon - check if **orcidAccessToken** is available ac6da40e-1826-43ed-987a-18323064a54709 - https://github.com/pkp/orcidProfile - **orcidAccessExpiresOn** 2041-05-06 12:47:32 - **orcidAccessScope** /activities/update - main branch installation - github actions - ## 16.4.2023 - user accected payload will stay after the reviewer accepts the inviation - validations pending - ## 9.4.2023 - Check Dimtris' implementations - acceptInvitation - - Current status - Discuss: Create user-account , only if cancel , what happends - If the email adress for the invitation, does not change, we can check for the email adress and show the added user metadata - - Preparation for the 11.4.24 PKP Meeting - OA Tage - Dulip booked - Köln City Mediapark ## 22.3.21 - Update of the status - ## 19.3.24 - PRs - API answer from Jarda should clear th - Here we have to find a strategy. ` The URL for this looks like .../invitation/accept?id=123&key=ABCDEF. This URL calls up a generic handler PKPInvitationHandler that's used for all kinds of invitations, not just invitations to join the journal. (I see in the PR that there's code specific to e.g. adding accounts -- that shouldn't be here.) The handler gets the invitation from the database, then delegates the next steps to the $invitation object using acceptHandle(), because only the invitation knows what to do next. In this case, it's a RegistrationAccessInvite.` - TODO: Deleting the accepted invitation. - automatically deleting the invitation, can be tricky for proofing, should we preserve it ? ## 15.3.24 - [Accept Handle as a seperate - PR](https://github.com/pkp/pkp-lib/blob/30fad0dc5fb46c694cfb4b0c645e4715d8973752/classes/invitation/invitations/RegistrationAccessInvite.php#L76) - TODO: ask Dimitirs - https://github.com/pkp/ojs/pull/4213/files - [Prposal](https://hackmd.io/tDCUwlwzTGi6HLGtKNs8lQ?edit) - TIB basic idea inserted: TSV do next week - - ## 12.3.24 - GRPR saving of user email in invitation: confirmed - Install server https://craft-test.online/9658 https://git.tib.eu/tib-op-projects/craft-oa/wp4/-/wikis/CRAFT-test.online - https://craft-test.online/readme/#/ ## 23.2.24 ### Ticket - https://github.com/pkp/pkp-lib/issues/9658 ### Summary of PRS - https://github.com/pkp/ui-library/pull/310 - https://github.com/pkp/pkp-lib/pull/9646 - ## 20.2.24 - Ipula - vue js need a mechanism to add a csfr token - Current user csrf token is not from the current user, although we can get it from the session - Current: Dynamic compontent - Next: API Request, Invitation table, Documentation - https://github.com/pkp/pkp-lib/issues/9658 - - Dulip - Holidays - GDPR - https://github.com/pkp/pkp-github-actions - https://jhove.openpreservation.org/ - ## 16.2.24 - Time slots for holidays - 26.02 - 08.03 - 25.03 - 05.04 - Server data from Antti-Jussi - Ticket - https://github.com/pkp/pkp-lib/issues/9658 - Figma link now seems to work https://github.com/pkp/pkp-lib/issues/9658 - Bozana did not come still - Verify orcid work ## 26.1.24 - branches are seperated - component restructuring - Next steps: email templates - Invitation acceptance part ## 23.1.24 - Current Update - Storybook - labels not showing - Modal dialog content is not passed - When the user is not found, there is an unncessary error message. - Roles table - Oranizational - Tomorrow meeting - commit the changes - - Devika will create smaller issues to separate user invitation and author invitation, and also seprate orcid workflow - Touhidur is working on moving laralvel cookies to OJS - Next steps - rebase - create user ## 19.1.24 - add the gtoups to the invivation groups for users without groups, start and end date for the role - Validation PR Two points - - Invite needs - API change ## 11.1.24 PKP Meeting - So far - Step 3 : [Modify details Email shared with user](https://www.figma.com/file/yChv7IhbfwFQqjU66JbPGs/Flow-for-JII-and-Craft-OA?type=whiteboard&node-id=470-789&t=sAWdQZZ1FiDZjTCt-0) :ok: - - Inviting users to a role in OJS - Step 1 : Search user : Demo :ok: - WIP: https://github.com/pkp/ui-library/pull/310/ - Next steps - Sroy book migration of step 1 - Backend Support : [OJS API](https://docs.pkp.sfu.ca/dev/api/ojs/3.4#tag/Users/paths/~1users/get) extension to returen first and second name, separately. ## 9.1.24 - Dulip - For the meeting on Thursday - Small demo of the steps implemented so far. - [We check the start and end date is ok for us](https://github.com/pkp/pkp-lib/issues/9462) - Jarda: For the users API add an end-point to return user first name and last name separately (dulip) - Role compontent : Work on the API, work on accept and reject - Thursday meeting 4.2 metopes jats to tei - - Ipula - Current status of the PR - - protocol from Jarda discussion - 5.1.2024 - Ipula - https://github.com/pkp/pkp-lib/pull/9404 - Problem: passing paramters to the vuejs - pinestore - First form: - Dulip - https://github.com/pkp/pkp-lib/pull/9404 - Plan to PR - update your forks main branch, both ojs and pkp-lib - Pull the main branch from your branch locally - create a new branch from the main branch - merge the changes in your development branch to the new branch - develop further in the newer branch - After finishing - rename the new branch to old branch - and force push - **Alec write about the API** - --- # 2023 ## Ipula - Search API - - Returns 200 : managing error messages - Confirm with Jarda - VueJs validation for the mandatory form fields in frontend for search field - WIP - styling - Composition API - Only remaining the search for Endpoint - users API returns Fullname , we would need given and family name ? - ## Dulip - Tomorrow meeting - Above questions - Organizational - - - PRS - [PKP-lib](https://github.com/pkp/pkp-lib/pull/9646) - [PKP-ui-library](https://github.com/pkp/ui-library/pull/310) - Issue - Edit the existing inviation record - TODO: link to the github code link ~~- Remember Alec about the user role start and end date ~~ ``` ```