# run "make caravel-sta" error
- When get project from `git clone -b mpw-8c https://github.com/efabless/caravel_user_project`

## error log when run "make caravel-sta"

exec> read_spef -path chip_core/soc.core.RAM128 /home/tonyho/workspace/debug/d3_caravel_user_project/caravel_user_project/mgmt_core_wrapper/signoff/RAM128/openlane-signoff/spef/RAM128.nom.spef
Error: timing_top.tcl line 60, path instance 'chip_core/soc.core.RAM128' not found.
make[1]: *** [/home/tonyho/workspace/debug/d3_caravel_user_project/caravel_user_project/deps/timing-scripts/timing.mk:244: caravel-timing-typ-nom] Error 1

## workaround in https://github.com/TonyHo722/timing-scripts

(base) tonyho@ubuntu5:~/workspace/debug/d3_caravel_user_project/caravel_user_project/deps/timing-scripts$ git log 3538543 -p
commit 3538543df11047ed7b8ad329d931fa138dcc3ff1 (main)
Author: tonyho <[e-mail]>
Date:   Mon Sep 4 17:22:54 2023 +0800

    patch for make caravel-sta Error issue

diff --git a/scripts/openroad/timing_top.tcl b/scripts/openroad/timing_top.tcl
index de7ac19..3eeae93 100644
--- a/scripts/openroad/timing_top.tcl
+++ b/scripts/openroad/timing_top.tcl
@@ -1,5 +1,5 @@
 source $::env(TIMING_ROOT)/env/common.tcl
-source $::env(TIMING_ROOT)/env/caravel_spef_mapping-mpw9.tcl
+source $::env(TIMING_ROOT)/env/caravel_spef_mapping-mpw7.tcl
 
 if { [file exists $::env(CUP_ROOT)/env/spef-mapping.tcl] } {
     source $::env(CUP_ROOT)/env/spef-mapping.tcl

[commit link](https://github.com/TonyHo722/timing-scripts/commit/3538543df11047ed7b8ad329d931fa138dcc3ff1)

## root cause - Makefile always get the last commit by `git pull`

$(TIMING_ROOT):
	@mkdir -p $(CUP_ROOT)/deps
	@git clone $(timing-scripts-repo) $(TIMING_ROOT)

.PHONY: setup-timing-scripts
setup-timing-scripts: $(TIMING_ROOT)
	@( cd $(TIMING_ROOT) && git pull )
	@#( cd $(TIMING_ROOT) && git fetch && git checkout $(MPW_TAG); )
	@python3 -m venv ./venv 
		. ./venv/bin/activate && \
		python3 -m pip install --upgrade pip && \
		python3 -m pip install -r $(TIMING_ROOT)/requirements.txt && \
		deactivate

[Makefile link](https://github.com/TonyHo722/caravel_user_project/blob/7f7c16f19280201d19bc4bf2d134cbc5906765b5/Makefile#L269C1-L281C13
)
- use `@( cd $(TIMING_ROOT) && git pull ) always get the last commit`
- change to `@( cd $(TIMING_ROOT) && git fetch && git checkout $(MPW_TAG); )` to get TAG:mpw-8c commit

### the commit in [efabless/timing-scripts](https://github.com/efabless/timing-scripts)

168b53a (HEAD -> main, tag: mpw-9d, origin/main, origin/HEAD) update `env/common.tcl`: (#14)

[Link of last commit I got @ 2023/9/5](https://github.com/efabless/timing-scripts/commit/168b53a8c92655a37924d6338149bf5a5ec8838c)

78c7a61 (tag: mpw-8c) Merge pull request #11 from efabless/recrem-summary

[Link of TAG:mpw-8c commit](https://github.com/efabless/timing-scripts/commit/78c7a615689c998acfec9743b65a38121a23c82b)

## final solution - update Makefile to use `git checkout $(MPW_TAG)`

	#( cd $(TIMING_ROOT) && git pull )
	( cd $(TIMING_ROOT) && git fetch && git checkout $(MPW_TAG); )

[commit link](https://github.com/TonyHo722/caravel_user_project/commit/419e2e92ddd18040cbae5b56f8e1d2170f6a1b61)