# Solidly

To-dos: Solidly UI Adjustments

## Not Done
### High Priority
#### General
- [ ] Add a network selector besides the user address, so instead of grey-ing out the whole screen, network selector will become red (see app.uniswap.org), allowing user to choose a network (in the start only Ethereum in prod, Fantom for testing)

#### Liquidity
- [ ] Show APR of providing liquidity for given pair of current epoch

#### Vote
- [ ] Show voting APR (i.e. what APR a veNFT for given pair got in fees for current epoch)
- [ ] Show current epoch's votes abs+% in one column and next week's votes in another (new) column

## Done
### Swap interface
- [x] Fix price impact issues where price impact is shown as 0%, possibly leading to loss of user funds if not carefully controlled by user
- [x] Move the interface up to match the lower interfaces on the other pages (such as vote page main body)
- [x] Move up even higher, 40% more of current space/distance.

- [x] Swap interface: There was a UX regression, balance is not clickable anymore (and thus doesn’t auto-fill) → make clickable again

- [x] Remove ugly & huge bar on the top of the page. If something is needed for scrolling, limit it to a small background bar like in the original UI, keep it round and minimal, color scheming is OK.

- [x] With the bar being completely removed in 3, there's a problem on pages where users can scroll, we have text-on-text overlay. To solve for this, introduce small rectangular background like the in picture above with the original bar opacity and only trigger it when user=scrolls and user=|=default position. Once back in default position, the bar should disappear again after 3 seconds.

- [x] When using the swap interface, an error is thrown each time when putting a 0 or a comma before a positive number, i.e. when writing 0.03 FTM for a USDC swap, the UI throws 3 "execution reverted" errors in total, for "0", "." and "0" before finally not throwing an error anymore after "3" is entered.

- [x] When clicking into the white slippage field, the cursor should activate no matter where you click in the white field, currently you need to click near the "2" to activate cursor, see picture above for reference.

- [x] "% Slippage" text should line up horizontally with input number. Furthermore the field should be enlarged a bit horizontally, because input number doesn't fully show when using 3 or more characters (i.e. using a comma)
Example 12.5%:

- [x] Swap fields overlap with "Balance:" text. Please increase height of field a bit, even with the "..." there are instances of overlay. Doesn't give a good impression.

- [x] 9. Price impact numbers seem very off sometimes (for example 600k FTM per YFI doesn't trigger a price impact alert). What reference price is being used? Maybe compare price impact to an aggregate number of Coingecko, CMC and internal oracle?
- We are triggering a price impact alert but in general need to test impacts and routing

- [x] Show "Price Impact" and "Minimum received after slippage", Uniswap as reference
- We now show price impact. We do not show minimum received after slippage, I think this clutters up the UI

### Liquidity page
- [x] Completely broken / does not load
- [x] Do subgraph work and hook up to liquidity page to make it load faster

### Rewards
- [x] Popup window showing and linking (to ftmscan.com) bribe claim went missing

### General
- [x] Change HTML color code of the bar on the top i.e. "Swap, Liquidity" etc, from HTML 646464 to HTML 525252 in order to increase redability/contrast

### Vote page
- [x] Remove negative voting
- [x] Change color of the slider line to the same blue as the vote button and fix alignment
- [x] NFT selection UI not looking good, also should make that clicking that whole field triggers selector popup.

## Won't fix
### General
- [x] The whole website must be able to be accessed without connecting a wallet, even showing voting numbers, APRs, etc. (i.e. not like Velodrome, where browsing is allowed but zero information is showed)
- Won't fix, requires a high amount of effort

### Swap
- [x] Asset selection window opacity is too low for older browsers (specifically for Firefox extended release version). Check other browsers as well: Chromium, Edge, Brave
- Won't fix/Low priority, supporting old browsers condtionally is a huge undertaking. Tell users to upgrade