# Centralized feedback - QA

## Design System - general (Silviu)

* Base resolution - 1920x1080
* Grid system - 12 columns
* 4 modal sizes – XS, S, M, L (width TBD)
* Typography – headers, body, forms, tables, modals, etc (size/weight/color TBD)
* Buttons – types (primary/secondary) and sizes (S, M, L) TBD
* Headers – 1 primary button rule + spacings
* Preview player – regular vs small

## Inconsistencies

* Selected item highlighting needs to be consistent (ex. drop shadow/blue border) (**Silviu**)
* Use toggles only for Boolean actions (true/false), not for 2 different states on the same control (**Silviu**)
* Errors are sometimes too technical and not displayed in the form (if, for example, an input field has a wrong value) (**Silviu**)

## Bad Practices
* Error handling - Form error validation behavior (currently all errors are displayed before any input) + errors thrown when reloading page (**Silviu**)
* Back button in connect currently replicates the browser back button functionality, which makes it redundant. Either remove it, or have it work inside the platform, separate from the browser button. Examples of weird behavior:
* if you open a new windows that already has a back button, the button is not functional.
* if you arrive from a different site in Connect and you hit back, it gets you out of the platform (**Bogdan Avram**)
* When selecting one or more CPL-s in order to create a package, the user has no overview as to what CPL-s he has selected, how many and, if there is pagination, on what pagination he can find them. The best option, as agreed by Silviu, was to add a "Selected items" feature after selecting one or more CPL-s from the list. (**Razvan**)
* Rename one dropdown "CPL Plugins" (left) and the other one "AppBar Plugins" (right) to be consistent with their content. (**Mihaela**)
* In the video preview screen, if I want to mute the sound, I hover the volume icon. But then it moves to the left to reveal the volume bar and I have to follow it, being careful not to move the cursor outside the area or it will close and I have to start again. Please see the behavior on the Youtube player which is way more intuitive and friendly. If the user's intention is to click on a button, then that button should't change its place just when they're about to do so. (**Mihaela**)

* ***

* Radio buttons instead of checkboxes in single select tables (**Silviu**)
* Setting initial password for a new user – system doesn’t show password requirements beforehand, just shows error if they’re not accomplished (**Silviu**)
* Anywhere it is possible to expand a list, the theme of the site doesn't clearly show what was expanded and the items contained by it.
Expand a package inside an asset or expand a timeline when creating an IMF package and it will be clear that the way in which the list expands is confusing. (**Teddy**)

## Improvement suggestions

* Search drop-downs should show (some) values if the user presses the down arrow – right now there is nothing shown until the user start typing (**Silviu**)
* Media item icon should show ingest status by color code (eliminate ingest icon) (**Silviu**)
* Ability to copy templates/profiles from one org to another (**Silviu**)
* Create New button from app header should be customizable, org based. (**Bogdan**)
* Dropdowns - Global - Would be nice to be able to filter the results as I type. (eg.: open dropdown - hit "r" on the keyboard - the dropdown filters and shows only items containing "r"). (**Mihaela**)
* The new interface is too crowded in the asset. The preview player could be closed in the past but now it is visible at all times.
The appearance of the page appears too "stuffed" with information (asset navigator to the left, media items list in the middle and preview player + file details on the right). (**Teddy**)
* Personal taste: The theme of the site is too dark and hard on the eyes (dark background, black background for the pages, dark blue text, red errors and so on). It may be modern (even WhatsApp recently got a dark theme) but maybe a new theme/ability to change it would help too :sweat_smile: (**Teddy**)
* When viewing a batch, you only see the batch info at the top and the jobs listed below, grouped in the platform-package template sections.
You do not know where the delivery will be made at first glance but need to open each job individually to see where the deliverable file will be copied.
A preview with the platform destination probably would be beneficial to the user (I'm thinking of the operators that are not allowed to create platform but only jobs/batches). (**Teddy**)
* In the Media items menu is more noticeable but it's a general issue, the filters present at the top of a page are listed randomly and not in the same order as the columns. While not an issue per say, it looks messy. (**Teddy**)
* The order of the buttons from the left side menu is not natural and doesn't allow the user to "flow" through them from top to bottom as to have everything ready when he reaches the end.
Now he needs to go up and down constantly to create what he needs.
For example: If you need/want a Job to create a composition and deliver it, you need to go to Profiles>Bug, Profiles>Timed text to create the image bug profile and select the display settings for the subtitle, then go down some more to Transcoder and edit it for your TT/SCC needs (they are not universal).
After that you need to go up to Tags to create tags for the items required (video, audio track, timed text and bug/image) after that go down a bit to Teamplates>Composition and create your composition.
But wait, we're not done yet, go up a bit to Templates>Packages and create/edit a package template with a Composition deliverable (in which you set the composition template from earlier, transcoder profile and name format).
Once these are done, go to Assets and put the tags to the files you want then go down again to Platforms and add the package template to one of the delivery platforms desired.
Only now you can create a job from the Jobs menu (yes, go up again) :smiling_face_with_smiling_eyes_and_hand_covering_mouth: (**Teddy**)
* When creating an asset, you also need an "Entity type". This is created from the Metadata Settings menu, Classification tab.
After a classification is created by pressing on the "Add new entity type" button from the header, you can use it on an asset.
The fields set in this new entity type/classification can be found in an asset in the Metadata Sets tab or in the Details tab, in the Entity Type field. You can find the same thing under multiple names depending on where you look. (**Teddy**)
* Same location as above, when creating jobs from the Jobs menu, it isn't clearly presented to the user that the Package template is dependent to the Platform (needs to be linked to the selected Platform). Right now, if you select a package template but then select a platform and they aren't linked, the template will be removed. You do not get any hints about the link being needed. (**Teddy**)
* Add helpful filters or search field to Workflows page (it would be nice to be able to search for a file/asset for example) (**Cristina**) - also Workflows page should be improved in order to make it more usable (for bulk operations, if you close the import dialog, that's the only place where you can see the workflows) - check also https://ownzones.atlassian.net/browse/CD-5048

* **

* Containers should expand when clicking anywhere on the header (currently works only when clicking the arrow) (**Silviu**)
* Number input field revamp – currently has 2 minuscule arrows on the right (**Silviu**)
* Media Warp - Width and Height should be horizontally aligned, not vertically. Same for X Offset and Y Offset. (**Mihaela**)
* Remove unnecessary and almost invisible Close button. (**Mihaela**)

## Bugs

* Create Transcoder profile – the expandable containers are not consistent with the rest of the app (**Silviu**)
* CPL – if you delete the image (vid), there is no way to add it back unless you refresh the page (**Silviu**)
* If you start a batch and 1 job has an error, the app doesn’t show it. If you start just that that particular job, the error is displayed. (**Silviu**)
* Drop-down shows first value as hovered on by default (**Silviu**)
* CPL screen – if no issues are present, the button should not be clickable (**Silviu**)
* Create tags button is asset details page doesn't look like a button (**Silviu**)
* In an asset, you have the Timelines tab that has a Create new button. Pressing it opens "Create new CPL" menu.
From the header, in any other menu, you have Create new>CPL.
CPL = Composition PlayList
The Compositions where renamed Timelines in a ticket but only the tab name. In other locations the old acronym still remains present.
In the asset they are named Timelines, in the editor they are CPL while the error menu list refferes to them as Composition. (**Teddy**)
* Asset Page - Timelines Tab - The options in the hamburger menu are overlapping the player and media info in the right side (just the same as it is in the Media Tab), but here the background of the options is transparent and looks awful. (**Stere**)
* When creating jobs from the Jobs menu you can select the desired materials (asset, package template, platform and so on) but if you select an existing batch with too many parameters, a too long job name format or type a very long job name, you will get an error when you press on the "Save" button. Perhaps a dynamic counter or some kind of dynamic preview for the resulting job name would help.
The error received is clear for us but needing to reduce the job name letter by letter until it matches the validation is cumbersome as the name limit is nowhere clearly presented. (**Teddy**)