- [ ] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> token-vault/program/src/processor.rs:307:41 | 307 | assert_owned_by(fraction_mint_info, &token_program_info.key)?; | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `token_program_info.key` | = note: `#[warn(clippy::needless_borrow)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> token-vault/program/src/processor.rs:308:45 | 308 | assert_owned_by(fraction_treasury_info, &token_program_info.key)?; | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `token_program_info.key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> token-vault/program/src/processor.rs:852:9 | 852 | &program_id.as_ref(), | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `program_id.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> token-vault/program/src/processor.rs:967:9 | 967 | &program_id.as_ref(), | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `program_id.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> token-vault/program/src/processor.rs:970:62 | 970 | let (authority, _) = Pubkey::find_program_address(seeds, &program_id); | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> token-vault/program/src/utils.rs:100:43 | 100 | &system_instruction::transfer(&payer_info.key, new_account_info.key, required_lamports), | ^^^^^^^^^^^^^^^ help: change this to: `payer_info.key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> token-vault/program/src/utils.rs:113:11 | 113 | &[&signer_seeds], | ^^^^^^^^^^^^^ help: change this to: `signer_seeds` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> token-vault/program/src/utils.rs:120:11 | 120 | &[&signer_seeds], | ^^^^^^^^^^^^^ help: change this to: `signer_seeds` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> token-vault/program/src/utils.rs:271:52 | 271 | let (key, bump) = Pubkey::find_program_address(&path, program_id); | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: `spl-token-vault` (lib) generated 9 warnings Checking spl-token-metadata v0.0.1 (/home/qi/Burnt/corebuild-c4860fc15aa67ddad7ad5ee3d252e019a278faae/rust/token-metadata/program) - [x] warning: this `else { if .. }` block can be collapsed --> token-metadata/program/src/utils.rs:111:32 | 111 | } else { | ________________________________^ 112 | | if creator.verified { 113 | | return Err(MetadataError::CannotVerifyAnotherCreator.into()); 114 | | } 115 | | } | |_________________________^ | = note: `#[warn(clippy::collapsible_else_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if help: collapse nested if block | 111 ~ } else if creator.verified { 112 + return Err(MetadataError::CannotVerifyAnotherCreator.into()); 113 + } | - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> token-metadata/program/src/deprecated_processor.rs:63:13 | 63 | &mint_info.key.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `mint_info.key.as_ref()` | = note: `#[warn(clippy::needless_borrow)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> token-metadata/program/src/deprecated_processor.rs:108:9 | 108 | &mint_info.key.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `mint_info.key.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> token-metadata/program/src/deprecated_processor.rs:159:13 | 159 | &edition_account_info.key, | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `edition_account_info.key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: length comparison to zero --> token-metadata/program/src/deprecated_processor.rs:360:34 | 360 | if reservations.len() > 1 || reservations.len() == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `reservations.is_empty()` | = note: `#[warn(clippy::len_zero)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> token-metadata/program/src/processor.rs:152:9 | 152 | &program_id, | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> token-metadata/program/src/processor.rs:306:13 | 306 | &mint_info.key.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `mint_info.key.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> token-metadata/program/src/processor.rs:333:9 | 333 | &mint_info.key.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `mint_info.key.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> token-metadata/program/src/processor.rs:392:9 | 392 | &program_id, | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [ ] warning: unneeded `return` statement --> token-metadata/program/src/state.rs:120:14 | 120 | 2 => return Ok(Box::new(MasterEditionV1::from_account_info(account)?)), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return`: `Ok(Box::new(MasterEditionV1::from_account_info(account)?))` | = note: `#[warn(clippy::needless_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return - [x] warning: unneeded `return` statement --> token-metadata/program/src/state.rs:121:14 | 121 | 6 => return Ok(Box::new(MasterEditionV2::from_account_info(account)?)), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return`: `Ok(Box::new(MasterEditionV2::from_account_info(account)?))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return - [x] warning: unneeded `return` statement --> token-metadata/program/src/state.rs:122:14 | 122 | _ => return Err(MetadataError::DataTypeMismatch.into()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return`: `Err(MetadataError::DataTypeMismatch.into())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return - [x] warning: unneeded `return` statement --> token-metadata/program/src/state.rs:292:14 | 292 | 3 => return Ok(Box::new(ReservationListV1::from_account_info(account)?)), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return`: `Ok(Box::new(ReservationListV1::from_account_info(account)?))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return - [x] warning: unneeded `return` statement --> token-metadata/program/src/state.rs:293:14 | 293 | 5 => return Ok(Box::new(ReservationListV2::from_account_info(account)?)), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return`: `Ok(Box::new(ReservationListV2::from_account_info(account)?))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return - [x] warning: unneeded `return` statement --> token-metadata/program/src/state.rs:294:14 | 294 | _ => return Err(MetadataError::DataTypeMismatch.into()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return`: `Err(MetadataError::DataTypeMismatch.into())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return - [x] warning: manual implementation of an assign operation --> token-metadata/program/src/state.rs:605:9 | 605 | self.ledger[index] = self.ledger[index] | mask; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.ledger[index] |= mask` | = note: `#[warn(clippy::assign_op_pattern)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern - [x] warning: the loop variable `j` is only used to index `creators` --> token-metadata/program/src/utils.rs:68:30 | 68 | for j in (i + 1)..creators.len() { | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_range_loop)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 68 | for <item> in creators.iter().skip((i + 1)) { | ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> token-metadata/program/src/utils.rs:165:43 | 165 | &system_instruction::transfer(&payer_info.key, new_account_info.key, required_lamports), | ^^^^^^^^^^^^^^^ help: change this to: `payer_info.key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> token-metadata/program/src/utils.rs:180:11 | 180 | &[&signer_seeds], | ^^^^^^^^^^^^^ help: change this to: `signer_seeds` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> token-metadata/program/src/utils.rs:187:11 | 187 | &[&signer_seeds], | ^^^^^^^^^^^^^ help: change this to: `signer_seeds` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [ ] warning: question mark operator is useless here --> token-metadata/program/src/utils.rs:234:5 | 234 | Ok(unpack_coption_key(&authority_bytes)?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unpack_coption_key(&authority_bytes)` | = note: `#[warn(clippy::needless_question_mark)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark - [x] warning: this expression borrows a reference (`&[u8; 36]`) that is immediately dereferenced by the compiler --> token-metadata/program/src/utils.rs:234:27 | 234 | Ok(unpack_coption_key(&authority_bytes)?) | ^^^^^^^^^^^^^^^^ help: change this to: `authority_bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [ ] warning: question mark operator is useless here --> token-metadata/program/src/utils.rs:243:5 | 243 | Ok(unpack_coption_key(&authority_bytes)?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unpack_coption_key(&authority_bytes)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark - [x] warning: this expression borrows a reference (`&[u8; 36]`) that is immediately dereferenced by the compiler --> token-metadata/program/src/utils.rs:243:27 | 243 | Ok(unpack_coption_key(&authority_bytes)?) | ^^^^^^^^^^^^^^^^ help: change this to: `authority_bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> token-metadata/program/src/utils.rs:321:15 | 321 | &[&mint_authority_info.key], | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `mint_authority_info.key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> token-metadata/program/src/utils.rs:334:22 | 334 | Some(&edition_key), | ^^^^^^^^^^^^ help: change this to: `edition_key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> token-metadata/program/src/utils.rs:337:19 | 337 | &[&mint_authority_info.key], | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `mint_authority_info.key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> token-metadata/program/src/utils.rs:368:9 | 368 | &mint.as_ref(), | ^^^^^^^^^^^^^^ help: change this to: `mint.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: unneeded `return` statement --> token-metadata/program/src/utils.rs:426:17 | 426 | return Err(MetadataError::AddressNotInReservation.into()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return`: `Err(MetadataError::AddressNotInReservation.into())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return - [x] warning: unneeded `return` statement --> token-metadata/program/src/utils.rs:430:9 | 430 | return Err(MetadataError::ReservationNotSet.into()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return`: `Err(MetadataError::ReservationNotSet.into())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return - [ ] warning: use of `offset` with a `usize` casted to an `isize` --> token-metadata/program/src/utils.rs:511:13 | 511 | mut_array_refs![output, 1, 8, MAX_MASTER_EDITION_LEN - 8 - 1]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast = note: this warning originates in the macro `mut_array_refs` (in Nightly builds, run with -Z macro-backtrace for more info) - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> token-metadata/program/src/utils.rs:553:9 | 553 | &mint_info.key.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `mint_info.key.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> token-metadata/program/src/utils.rs:578:9 | 578 | &program_id, | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> token-metadata/program/src/utils.rs:595:9 | 595 | &mint_info.key.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `mint_info.key.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> token-metadata/program/src/utils.rs:732:52 | 732 | let (key, bump) = Pubkey::find_program_address(&path, program_id); | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [ ] warning: `spl-token-metadata` (lib) generated 35 warnings Checking spl-metaplex v0.0.1 (/home/qi/Burnt/corebuild-c4860fc15aa67ddad7ad5ee3d252e019a278faae/rust/metaplex/program) - [x] warning: this function has too many arguments (15/7) --> metaplex/program/src/instruction.rs:816:1 | 816 | / pub fn create_deprecated_populate_participation_printing_account_instruction( 817 | | program_id: Pubkey, 818 | | safety_deposit_token_store: Pubkey, 819 | | transient_one_time_mint_account: Pubkey, ... | 831 | | payer: Pubkey, 832 | | ) -> Instruction { | |________________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/claim_bid.rs:57:11 | 57 | &[&signer_seeds], | ^^^^^^^^^^^^^ help: change this to: `signer_seeds` | = note: `#[warn(clippy::needless_borrow)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/claim_bid.rs:132:30 | 132 | &[PREFIX.as_bytes(), &auction_manager.auction.as_ref()], | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/claim_bid.rs:136:9 | 136 | &auction_manager.auction.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/decommission_auction_manager.rs:71:30 | 71 | &[PREFIX.as_bytes(), &auction_info.key.as_ref()], | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_info.key.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/decommission_auction_manager.rs:74:48 | 74 | let authority_seeds = &[PREFIX.as_bytes(), &auction_info.key.as_ref(), &[bump_seed]]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_info.key.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this function has too many arguments (12/7) --> metaplex/program/src/processor/deprecated_populate_participation_printing_account.rs:27:1 | 27 | / fn mint_printing_tokens<'a: 'b, 'b>( 28 | | program: &AccountInfo<'a>, 29 | | destination: &AccountInfo<'a>, 30 | | token: &AccountInfo<'a>, ... | 39 | | authority_signer_seeds: &'b [&'b [u8]], 40 | | ) -> ProgramResult { | |__________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/deprecated_populate_participation_printing_account.rs:101:66 | 101 | let safety_deposit_token_store: Account = assert_initialized(&safety_deposit_token_store_info)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `safety_deposit_token_store_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/deprecated_populate_participation_printing_account.rs:128:9 | 128 | &safety_deposit_info, | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `safety_deposit_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/deprecated_populate_participation_printing_account.rs:129:9 | 129 | &vault_info, | ^^^^^^^^^^^ help: change this to: `vault_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/deprecated_populate_participation_printing_account.rs:213:34 | 213 | &[PREFIX.as_bytes(), &auction_manager.auction.as_ref()], | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/deprecated_populate_participation_printing_account.rs:218:13 | 218 | &auction_manager.auction.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/deprecated_validate_participation.rs:42:41 | 42 | let rent = &Rent::from_account_info(&rent_info)?; | ^^^^^^^^^^ help: change this to: `rent_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/deprecated_validate_participation.rs:81:9 | 81 | &safety_deposit_box_info, | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `safety_deposit_box_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/deprecated_validate_participation.rs:110:13 | 110 | &open_edition_metadata.mint.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `open_edition_metadata.mint.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/empty_payment_account.rs:279:41 | 279 | let rent = &Rent::from_account_info(&rent_info)?; | ^^^^^^^^^^ help: change this to: `rent_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/empty_payment_account.rs:410:13 | 410 | &safety_deposit_info.key.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `safety_deposit_info.key.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/empty_payment_account.rs:411:13 | 411 | &destination.owner.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `destination.owner.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/empty_payment_account.rs:421:9 | 421 | &safety_deposit_info.key.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `safety_deposit_info.key.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/empty_payment_account.rs:422:9 | 422 | &destination.owner.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `destination.owner.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/empty_payment_account.rs:464:34 | 464 | &[PREFIX.as_bytes(), &auction_manager.auction.as_ref()], | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/empty_payment_account.rs:469:13 | 469 | &auction_manager.auction.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/init_auction_manager.rs:67:30 | 67 | &[PREFIX.as_bytes(), &auction_info.key.as_ref()], | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_info.key.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/init_auction_manager.rs:75:13 | 75 | &store.auction_program.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `store.auction_program.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/init_auction_manager.rs:76:13 | 76 | &vault_info.key.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `vault_info.key.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/init_auction_manager.rs:154:48 | 154 | let authority_seeds = &[PREFIX.as_bytes(), &auction_info.key.as_ref(), &[bump_seed]]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_info.key.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this function has too many arguments (9/7) --> metaplex/program/src/processor/redeem_bid.rs:26:1 | 26 | / fn set_reservation_list_wrapper<'a>( 27 | | program_id: &'a Pubkey, 28 | | master_edition_info: &AccountInfo<'a>, 29 | | reservation_list_info: &AccountInfo<'a>, ... | 35 | | total_spot_offset: u64, 36 | | ) -> ProgramResult { | |__________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/redeem_bid.rs:53:11 | 53 | &[&signer_seeds], | ^^^^^^^^^^^^^ help: change this to: `signer_seeds` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/redeem_bid.rs:196:21 | 196 | &safety_deposit_info, | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `safety_deposit_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/redeem_bid.rs:210:42 | 210 | &[PREFIX.as_bytes(), &auction_manager.auction.as_ref()], | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/redeem_bid.rs:215:21 | 215 | &auction_manager.auction.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/redeem_full_rights_transfer_bid.rs:92:21 | 92 | &safety_deposit_info, | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `safety_deposit_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/redeem_full_rights_transfer_bid.rs:106:58 | 106 | let auction_seeds = &[PREFIX.as_bytes(), &auction_manager.auction.as_ref()]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/redeem_full_rights_transfer_bid.rs:108:65 | 108 | Pubkey::find_program_address(auction_seeds, &program_id); | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/redeem_full_rights_transfer_bid.rs:111:21 | 111 | &auction_manager.auction.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: casting integer literal to `u64` is unnecessary --> metaplex/program/src/processor/redeem_participation_bid.rs:217:52 | 217 | if bidder_token.amount.saturating_sub(price) < 0 as u64 { | ^^^^^^^^ help: try: `0_u64` | = note: `#[warn(clippy::unnecessary_cast)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/redeem_participation_bid.rs:368:30 | 368 | &[PREFIX.as_bytes(), &auction_manager.auction.as_ref()], | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/redeem_participation_bid.rs:375:17 | 375 | &auction_manager.auction.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [ ] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices --> metaplex/program/src/processor/redeem_printing_v2_bid.rs:30:12 | 30 | items: &Vec<WinningConfigItem>, | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[WinningConfigItem]` | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/redeem_printing_v2_bid.rs:110:11 | 110 | &[&signer_seeds], | ^^^^^^^^^^^^^ help: change this to: `signer_seeds` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this function has too many arguments (9/7) --> metaplex/program/src/processor/redeem_printing_v2_bid.rs:116:1 | 116 | / pub fn create_or_update_prize_tracking<'a>( 117 | | program_id: &'a Pubkey, 118 | | auction_manager_info: &AccountInfo<'a>, 119 | | prize_tracking_ticket_info: &AccountInfo<'a>, ... | 125 | | expected_redemptions: u64, 126 | | ) -> Result<u64, ProgramError> { | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/redeem_printing_v2_bid.rs:276:21 | 276 | &safety_deposit_info, | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `safety_deposit_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/start_auction.rs:35:11 | 35 | &[&signer_seeds], | ^^^^^^^^^^^^^ help: change this to: `signer_seeds` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/start_auction.rs:79:38 | 79 | let seeds = &[PREFIX.as_bytes(), &auction_manager.auction.as_ref()]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/start_auction.rs:80:62 | 80 | let (_, bump_seed) = Pubkey::find_program_address(seeds, &program_id); | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/start_auction.rs:83:9 | 83 | &auction_manager.auction.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/validate_safety_deposit_box.rs:142:9 | 142 | &safety_deposit_info, | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `safety_deposit_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/validate_safety_deposit_box.rs:237:9 | 237 | &metadata.mint.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `metadata.mint.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/validate_safety_deposit_box.rs:244:38 | 244 | let seeds = &[PREFIX.as_bytes(), &auction_manager.auction.as_ref()]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/validate_safety_deposit_box.rs:245:62 | 245 | let (_, bump_seed) = Pubkey::find_program_address(seeds, &program_id); | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/validate_safety_deposit_box.rs:248:9 | 248 | &auction_manager.auction.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/validate_safety_deposit_box.rs:270:17 | 270 | &auction_manager.auction.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/validate_safety_deposit_box.rs:275:79 | 275 | Pubkey::find_program_address(original_authority_lookup_seeds, &program_id); | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/validate_safety_deposit_box.rs:278:17 | 278 | &auction_manager.auction.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/withdraw_master_edition.rs:42:41 | 42 | let rent = &Rent::from_account_info(&rent_info)?; | ^^^^^^^^^^ help: change this to: `rent_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/withdraw_master_edition.rs:51:21 | 51 | assert_owned_by(&destination_info, token_program_info.key)?; | ^^^^^^^^^^^^^^^^^ help: change this to: `destination_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/withdraw_master_edition.rs:52:21 | 52 | assert_owned_by(&auction_manager_info, &program_id)?; | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/withdraw_master_edition.rs:52:44 | 52 | assert_owned_by(&auction_manager_info, &program_id)?; | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/withdraw_master_edition.rs:58:33 | 58 | assert_owned_by(store_info, &program_id)?; | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/withdraw_master_edition.rs:62:9 | 62 | &safety_deposit_info, | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `safety_deposit_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/withdraw_master_edition.rs:63:9 | 63 | &vault_info, | ^^^^^^^^^^^ help: change this to: `vault_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/withdraw_master_edition.rs:67:30 | 67 | assert_rent_exempt(rent, &destination_info)?; | ^^^^^^^^^^^^^^^^^ help: change this to: `destination_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [ ] warning: called `is_some()` after searching an `Iterator` with `find` --> metaplex/program/src/processor/withdraw_master_edition.rs:117:18 | 117 | .find(|i| i.safety_deposit_box_index == safety_deposit_box.order) | __________________^ 118 | | .is_some() | |__________________________^ help: use `any()` instead: `any(|i| i.safety_deposit_box_index == safety_deposit_box.order)` | = note: `#[warn(clippy::search_is_some)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some - [ ] warning: called `is_some()` after searching an `Iterator` with `find` --> metaplex/program/src/processor/withdraw_master_edition.rs:149:32 | 149 | let atleast_one_matching = auction_manager | ________________________________^ 150 | | .settings 151 | | .winning_configs 152 | | .iter() ... | 161 | | }) 162 | | .is_some(); | |__________________^ | = help: this is more succinctly expressed by calling `any()` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some - [ ] warning: called `is_some()` after searching an `Iterator` with `find` --> metaplex/program/src/processor/withdraw_master_edition.rs:154:13 | 154 | / c.items 155 | | .iter() 156 | | .find(|i| { 157 | | i.safety_deposit_box_index == safety_deposit_box.order 158 | | && i.winning_config_type == WinningConfigType::PrintingV2 159 | | }) 160 | | .is_some() | |__________________________^ | = help: this is more succinctly expressed by calling `any()` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/withdraw_master_edition.rs:179:30 | 179 | &[PREFIX.as_bytes(), &auction_manager.auction.as_ref()], | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/processor/withdraw_master_edition.rs:184:9 | 184 | &auction_manager.auction.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:99:9 | 99 | &token_vault_program, | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `token_vault_program` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:200:43 | 200 | &system_instruction::transfer(&payer_info.key, new_account_info.key, required_lamports), | ^^^^^^^^^^^^^^^ help: change this to: `payer_info.key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:215:11 | 215 | &[&signer_seeds], | ^^^^^^^^^^^^^ help: change this to: `signer_seeds` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:222:11 | 222 | &[&signer_seeds], | ^^^^^^^^^^^^^ help: change this to: `signer_seeds` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:266:11 | 266 | &[&signer_seeds], | ^^^^^^^^^^^^^ help: change this to: `signer_seeds` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:294:11 | 294 | &[&signer_seeds], | ^^^^^^^^^^^^^ help: change this to: `signer_seeds` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:316:15 | 316 | &[&mint_authority_info.key], | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `mint_authority_info.key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:332:18 | 332 | Some(&new_authority_key), | ^^^^^^^^^^^^^^^^^^ help: change this to: `new_authority_key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:335:15 | 335 | &[&mint_authority_info.key], | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `mint_authority_info.key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:468:41 | 468 | let rent = &Rent::from_account_info(&rent_info)?; | ^^^^^^^^^^ help: change this to: `rent_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:517:60 | 517 | Pubkey::find_program_address(&redemption_path, &program_id); | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:566:21 | 566 | assert_owned_by(&destination_info, token_program_info.key)?; | ^^^^^^^^^^^^^^^^^ help: change this to: `destination_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:567:21 | 567 | assert_owned_by(&auction_manager_info, &program_id)?; | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:567:44 | 567 | assert_owned_by(&auction_manager_info, &program_id)?; | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:570:46 | 570 | assert_owned_by(bid_redemption_info, &program_id)?; | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:575:33 | 575 | assert_owned_by(store_info, &program_id)?; | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:579:9 | 579 | &safety_deposit_info, | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `safety_deposit_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:580:9 | 580 | &vault_info, | ^^^^^^^^^^^ help: change this to: `vault_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:584:30 | 584 | assert_rent_exempt(rent, &destination_info)?; | ^^^^^^^^^^^^^^^^^ help: change this to: `destination_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:669:17 | 669 | &bid_redemption_info, | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `bid_redemption_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:670:17 | 670 | &rent_info, | ^^^^^^^^^^ help: change this to: `rent_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:671:17 | 671 | &system_info, | ^^^^^^^^^^^^ help: change this to: `system_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::account_info::AccountInfo`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:672:17 | 672 | &payer_info, | ^^^^^^^^^^^ help: change this to: `payer_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:778:9 | 778 | &auction_manager.auction.as_ref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `auction_manager.auction.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&solana_program::pubkey::Pubkey`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:783:71 | 783 | Pubkey::find_program_address(original_authority_lookup_seeds, &program_id); | ^^^^^^^^^^^ help: change this to: `program_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[u8]`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:841:9 | 841 | &mint.as_ref(), | ^^^^^^^^^^^^^^ help: change this to: `mint.as_ref()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [x] warning: this expression borrows a reference (`&[&[u8]]`) that is immediately dereferenced by the compiler --> metaplex/program/src/utils.rs:882:52 | 882 | let (key, bump) = Pubkey::find_program_address(&path, program_id); | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - [ ] warning: `spl-metaplex` (lib) generated 94 warnings