Daily Log 2020 === ![](https://i.imgur.com/V1maWD1.png) ## Thursday Oct 8th 2020 ### Work Project UNC ## Wednesday April 29th 2020 ### Work Project Givelify #### Tasks #### Code Review - [DP-1756] Add Campus Selector to Nav #236 - https://github.com/Givelify/donee-portal-ui/pull/236 - Recorded demo - Approved - [DP-1766] Update Shelby Next Integration #237 - https://github.com/Givelify/donee-portal-ui/pull/237 - Approved - No demo needed, will be covered when I demo integrations --- ## Tuesday April 28th 2020 ### Work Project Givelify Had a couple meetings to go over changes for Integrations and re-prioritize tasks. #### Tasks - [DP#1775] Add final formatting touches to donors csv export #249 - https://givelify15.atlassian.net/browse/DP-1775 - PR submitted: https://github.com/Givelify/donee-portal-api/pull/249 #### Code Review #### TIL Javascript dates are zero based. This means that `date.getUTCMonth()` will return `0` for January. --- ## Monday April 27th 2020 ### Work Project Givelify #### Tasks - Addressed feedback and merged PR's for DP#1551 (Donors Export) - Paired with Jacob on getting campuses added - adding the relationships - updating the policies - updating the routes - and adding new tests #### Code Review - [DP#1700] Add Bank Deposits to DP3 #229 - https://github.com/Givelify/donee-portal-ui/pull/229 --- ## Friday April 24th 2020 ### Work Project Givelify #### Tasks - [DP-1773] Add 'total received' aggregate to Donors report - PR submitted and merged 🤘 - [DP#1774] Add 'total refunded' to donors export report' - PR submitted - [DP#1771] Add total donated to donors export - PR submitted - [DP#1801] Add constraints to eager loaded relationships on donors export - PR submitted #### Code Review - [DP#1700] Add Bank Deposits to DP3 #229 - https://github.com/Givelify/donee-portal-ui/pull/229 - 1400+ lines 😬🐱‍👤 --- ## Thursday April 23rd 2020 ### Work Project Givelify - Meetings! - Internal meetings from 9:30 - 9:50 - Syncup on integrations design changes at 10pm for about an hour - Daily standup from 11-11:25 #### Tasks - [DP-1772] Constrain included donors in donors report to the selected timeframe - PR submitted: https://github.com/Givelify/donee-portal-api/pull/232 - [DP-1773](/fcSL0kG_TSiNsvyOTFdRIg) Add 'total received' aggregate to Donors report - Work started #### Code Review - [DP#1769] Track UTM Code On Signup #217 - https://github.com/Givelify/donee-portal-ui/pull/217 #### TIL There is a syntax for injecting scripts into the `index.html` file of a create-react-app project through use of a webpack plugin: ```htmlmixed <% if (process.env.NODE_ENV === 'production') { %> <script> // my GA script </script> <% } %> ``` https://github.com/facebook/create-react-app/issues/3112 --- ## Wenesday April 22nd 2020 ### Work Project Givelify Demo prep: Features to include **Signup/signin** - ~~Password reset page / flow~~ (couldn't demo flow) - Verify email on signup (can't demo) - ~~Signup step validation~~ - ~~Signup review page~~ **Donors** - Donor report export (doesn't seem to be working in dev) - ~~Mobile views for donors page~~ - ~~Donation receipt modal~~ - ~~Visual tweaks to donors page ~~ - ~~Sorting donors~~ - ~~Memo history on donor profile~~ #### Tasks - Record and edit Sprint 16 demo - [DP-1772] Constrain included donors in donors report to the selected timeframe - https://givelify15.atlassian.net/browse/DP-1772 - Worked on adding new intigrations to frontend (no tickets for it yet as we'll be fleshing that out in Thursday's meeting) #### Code Review - [DP-1706] email address should be verified for login #226 - https://github.com/Givelify/donee-portal-api/pull/226 - Approved - [DP-1677] submit signup API-minor fix #227 - https://github.com/Givelify/donee-portal-api/pull/227 - [DP#1676] Signup Submitted Page #220 - https://github.com/Givelify/donee-portal-ui/pulls?q=is%3Apr+is%3Aclosed - Suggested changes - Approved --- ## Tuesday April 21st 2020 ### Work Project: Givelify #### Tasks - [DP#1474] Add export functionality to Donor Table - https://givelify15.atlassian.net/browse/DP-1474 #### Code Review - Feature/dp 1748 donation receipt modal #214 - https://github.com/Givelify/donee-portal-ui/pull/214 - Approved - Feature/dp 1745 donors page not aligned with designs for mobile #216 - https://github.com/Givelify/donee-portal-ui/pull/216 - Approved --- ## Monday April 20th 2020 ### Work Project: Givelify #### Tasks - [DP#1759] Finish donors report formatting for CSV download - https://givelify15.atlassian.net/secure/RapidBoard.jspa?rapidView=12&modal=detail&selectedIssue=DP-1759 - Submitted PR: https://github.com/Givelify/donee-portal-api/pull/225 #### Code Review - [DP#1692] Update Reset Password with new design #212 - https://github.com/Givelify/donee-portal-ui/pull/212 - Approved - [DP#1743] Reset password API from forgot email link #221 - https://github.com/Givelify/donee-portal-api/pull/221#pullrequestreview-396433890 - Approved - [DP#1684] DP 3.0 add new forgot password APIs #215 - https://github.com/Givelify/donee-portal-api/pull/215 - Approved - [DP-1762] Add donation breakdown to the donee donor donations #224 - https://github.com/Givelify/donee-portal-api/pull/224 - Approved --- ## Friday April 17th 2020 ### Work #### Tasks #### Code Review - [DP#1684] DP 3.0 add new forgot password APIs #215 - https://github.com/Givelify/donee-portal-api/pull/215 - No tests but will let through if other comments addressed - [DP#1743] Reset password API from forgot email link #221 - https://github.com/Givelify/donee-portal-api/pull/221 - No tests but approved - [DP#1692] Update Reset Password with new design #212 - https://github.com/Givelify/donee-portal-ui/pull/212 - approved --- ## Thursday April 16th 2020 ### Work #### Tasks - [DP#1554] Add `/download` to `DoneeDonors` endpoint - https://givelify15.atlassian.net/browse/DP-1554 - PR submitted: https://github.com/Givelify/donee-portal-api/pull/219 #### Code Review - [DP-1723] Donor Screen Not Aligned With Designs #211 - https://github.com/Givelify/donee-portal-ui/pull/211 - approved - [DP-1730] get donee officials titles API - signup process #220 - https://github.com/Givelify/donee-portal-api/pull/220 - approved --- ## Wednesday April 15th 2020 Project: Givelify ### Work - got stuck with failing test suite #### Tasks - Recorded and edited the Sprint 15 demo video - [DP#1554] Add `/download` to `DoneeDonors` endpoint - https://givelify15.atlassian.net/browse/DP-1554 #### Code Review - [DP-1491] donation activity- bank deposits #217 - https://github.com/Givelify/donee-portal-api/pull/217 ## Tuesday April 14th 2020 ### Work #### Tasks - Scoping/investigating campuses - [DP#1554] Add `/download` to `DoneeDonors` endpoint https://givelify15.atlassian.net/browse/DP-1554 #### Code Review ## Monday April 13th 2020 ### Work #### Tasks - [DP#1703] https://givelify15.atlassian.net/browse/DP-1703 - Fixing the flash on integrations page - Submitted PR: https://github.com/Givelify/donee-portal-ui/pull/206 - [DP#1721] https://givelify15.atlassian.net/browse/DP-1721 - Integration settings screen doesn't match designs - Blocked (there are no designs) #### Code Review - https://github.com/Givelify/donee-portal-api/pull/216 - https://github.com/Givelify/donee-portal-api/pull/215 - https://github.com/Givelify/donee-portal-ui/pull/204 - https://github.com/Givelify/donee-portal-ui/pull/205 - https://github.com/Givelify/donee-portal-ui/pull/198 ## Thursday April 9th 2020 ### Work - Change in focus at a high level. Signup process is becoming more important so Hafiz and Peyman are focused on that now. As we wrap up the donors feature we're going to pivot back to Integrations and Dashboards while the design team continues development of the rest of the sections - There is a big demo scheduled for tomorrow with the stakeholders. So donors is on pause for today as we triage and fix and easy bugs or polish in those two sections. - Priority is still on sigup, so we'll be reviewing and/or assisting any work related to signup. #### Tasks - Spent the first part of the morning doing some QA on integrations and dashboards, triaging. - [DP-1704 100% Matched Donor/Envelope Behaviour](https://givelify15.atlassian.net/browse/DP-1704) - Changing the "almost done" label to "done" when 100% complete - Disabling the matching links when progress is 100% **Left work early due to an ocular migrain** #### Code Review none ## Wednesday April 8th 2020 ### Work - Edits to demo video #### Tasks - [[DP#1963] Donors page breaks if a donor has no donations](https://givelify15.atlassian.net/browse/DP-1693) - PR submitted: https://github.com/Givelify/donee-portal-ui/pull/197 - Merged - - [[DP#1476] Add `PlacedInput` into Donors Table and connect to API](https://givelify15.atlassian.net/browse/DP-1476) - PR Submitted: https://github.com/Givelify/donee-portal-ui/pull/195 #### Code Review - [Connect Simple TextField to Redux #196](https://github.com/Givelify/donee-portal-ui/pull/196) - [Feature/dp 1472 connect donor profile donation history table to api #194](https://github.com/Givelify/donee-portal-ui/pull/194) - There were a few issues and feedback on the original submission yesterday warrenting a second code review ## Tuesday April 7th 2020 ### Work #### Tasks - [[DP#1477] - Create Reusable `PlacedInput` component for assigning Donor Internal IDs](https://givelify15.atlassian.net/browse/DP-1477) - Submitted PR - Merged - [[DP#1476] Add `PlacedInput` into Donors Table and connect to API](https://givelify15.atlassian.net/browse/DP-1476) - Recorded/edited demo video for Wednesday #### Code Review - [[DP#1581] DP 3.0 update forgotten password with new design #187](https://github.com/Givelify/donee-portal-ui/pull/187) - This was Tran's PR and due to the async nature of our collaboration I decided to suggest my changes as a commit: [f74509](https://github.com/Givelify/donee-portal-ui/pull/187/commits/f745098f9a551351902848c3b385141da7387d61) - [[DP#1315] Refresh Left Hand Navigation with new UI Design #191](https://github.com/Givelify/donee-portal-ui/pull/191) - Addressed some comments from the team with a commit: [6168ff](https://github.com/Givelify/donee-portal-ui/pull/191/commits/6168ff1efa7db5375219f6156a10d6149a92bdb7) - [Feature/dp 1472 connect donor profile donation history table to api #194](https://github.com/Givelify/donee-portal-ui/pull/194) ## Monday April 6th 2020 ### Work #### Tasks - [[DP#1477] - Create Reusable `PlacedInput` component for assigning Donor Internal IDs](https://givelify15.atlassian.net/browse/DP-1477) - Work started - Had to pivot to fix a bug with downloading reports - Have the basic functionality complete - [[1679] - Unable to download the reports](https://givelify15.atlassian.net/browse/DP-1679) - PR Submitted: https://github.com/Givelify/donee-portal-api/pull/210 - Merged #### Code Review - [DP#1655, 1653, 1656, 1648] Steps and Progress Bar | Full Signup Page Content | Text Field With OK Button | Redux State Setup #190 - Feature/dp 1471 connect donor profile to api #192 ## Thursday April 2nd 2020 ### Work #### Tasks - [[DP#1644] - DP 3.0 UI - Add infinite scroll to donors page](https://givelify15.atlassian.net/browse/DP-1644) - Had infinite scrolling working yesterday but realized I have to restructure the elements a bit. It's infinite scrolling the whole table instead of just the row, which I think is causing it to continue fetching new pages even when the user isn't scrolled to the bottom of the page. - Managed to get infinite scrolling working but with some minor issues - Ended up switching to standard pagination. Submitted PR and merged 🏄‍♀️ #### Code Review - [[DP#1601] 7 Minor Bug Fixes #183](https://github.com/Givelify/donee-portal-ui/pull/183) - [[DP#1652] Main Signup Page #185](https://github.com/Givelify/donee-portal-ui/pull/185) ## Wednesday April 1st 2020 ### Work #### Tasks - [[DP#1469] Connect donors table to API](https://givelify15.atlassian.net/browse/DP-1469) - Add debounce to search - Submitted PR: [Feature/dp 1469 connect donors table to api #181](https://github.com/Givelify/donee-portal-ui/pull/181) - Merged 🏄‍♀️ - [[DP#1644] - DP 3.0 UI - Add infinite scroll to donors page](https://givelify15.atlassian.net/browse/DP-1644) - work started #### Code Review - [DP#1623] Implement Infinite Loading #177 - [[DP-1456] Add DoneeDonorDonations Index endpoint #208](https://github.com/Givelify/donee-portal-api/pull/208) #### TIL TS/JS file structures can be confusing and I often struggle to find existing interfaces or types when they're burried inside a file with an unrelated name. This is simply solved by using your IDE to search for symbols. In VS Code it's done by typing `#` in your command pallete. For example if you're trying to find if an `Envelope` interface already exists somewhere: ![](https://i.imgur.com/9CTXfMj.png) ## Tuesday March 31st 2020 ### Work #### Tasks - [[DP#1469] Connect donors table to API](https://givelify15.atlassian.net/browse/DP-1469) - Table connected to API with filters and search #### Code Review forgot to fill out ## Monday March 30th 2020 ### Work #### Tasks - [[DP#1451] Add Donors Table to Cosmos](https://givelify15.atlassian.net/browse/DP-1451) - Addressing PR feedback #### Code Review - [[DP-1579] Add member_id to DoneeDonor index and show](https://github.com/Givelify/donee-portal-api/pull/204) - [[DP-1589] add messaging filter to get the donations total](https://github.com/Givelify/donee-portal-api/pull/205/files) - [[DP#1623] Implement Infinite Loading](https://github.com/Givelify/donee-portal-ui/pull/177) - [[DP-1452] Add Donor Profile to Cosmos](https://github.com/Givelify/donee-portal-ui/pull/179) ## Thursday March 26th 2020 (vacation day yesterday) ### Work #### Tasks - [[DP#1451] Add Donors Table to Cosmos](https://givelify15.atlassian.net/browse/DP-1451) - PR submitted #### Code Review - [[DP#1468] update donee donors index to support sorting and new filters](https://github.com/Givelify/donee-portal-api/pull/198) - [[DP-1607] Include Screenshots and GIFs into the PR template](https://github.com/Givelify/donee-portal-ui/pull/175) - [[DP#1605] Refactor donations activity page to use Redux](https://github.com/Givelify/donee-portal-ui/pull/174) ## Tuesday March 24th 2020 ### Work #### Tasks - [[DP#1451] Add Donors Table to Cosmos](https://givelify15.atlassian.net/browse/DP-1451) - Most of the work is done. Just pixel pushing to get the layout of the filters and search bar in the right places #### Code Review na ## Monday March 23rd 2020 ### Work Project: Givelify #### Tasks - [[DP#1450] Add `Donors` Route and Scaffolding](https://givelify15.atlassian.net/browse/DP-1450) - PR submitted: [[DP#1450] Add donors UI scaffolding](https://github.com/Givelify/donee-portal-ui/pull/169) - [[DP#1451] Add Donors Table to Cosmos](https://givelify15.atlassian.net/browse/DP-1451) - Work started #### Code Review - Helped investigate a QA bug with report generation: https://givelify15.atlassian.net/projects/DP?selectedItem=com.atlassian.plugins.atlassian-connect-plugin%3Acom.kanoah.test-manager__main-project-page#!/testCase/DP-T11 - [[DP-1454] Add show route to donee donors](https://github.com/Givelify/donee-portal-api/pull/197/files) ## Friday March 20th 2020 - Sick ## Thursday March 19th 2020 ### Work Project: Givelify #### Tasks - [[DP#1312] Append LastDownloadedByName to Report Response](https://givelify15.atlassian.net/browse/DP-1312) - PR submitted: [[DP#1231] Add 'last_downloaded_by_name' to Reports response](https://github.com/Givelify/donee-portal-api/pull/195) - PR merged 🕺 - [[1290] Populate Last Downloaded UI Fields](https://givelify15.atlassian.net/browse/DP-1290) - PR submitted [[DP#1290] Fill last downloaded fields in ui with API data](https://github.com/Givelify/donee-portal-ui/pull/166) - PR merged 🙌 ## Wednesday March 18th 2020 ### Work Project: Givelify #### Tasks - DP-1483 (dashboard fixes) and submitted for review - Submitted PR: [[DP#159] Dashboard fixes](https://github.com/Givelify/donee-portal-ui/pull/159) - Label "Overview For" was changed to "Overview" - Formatting of lifetime amount was changed to use commas for every thousands place value - Add year to copyright - Align time frame selector closer to left on large screens - [DP#1556 Selecting a timeframe with empty data can result in the page breaking](https://givelify15.atlassian.net/browse/DP-1556) - Submitted PR: [[DP#1556] Fix timeframe selector](https://github.com/Givelify/donee-portal-ui/pull/161) - [[DP#1312] Append LastDownloadedByName to Report Response](https://givelify15.atlassian.net/browse/DP-1312) - Work started #### Code Review - [[DP-1538] Add Donee Redux Domain to UI](https://github.com/Givelify/donee-portal-ui/pull/160) - [[DP#1393] Hook up Messenger to the back-end](https://github.com/Givelify/donee-portal-ui/pull/156) - [[DP-1539] Connect Donee Redux to API Endpoint](https://github.com/Givelify/donee-portal-ui/pull/162)