## Merge Request pre-flight checklist

[*General guidelines in Confluence*](https://spaceflow.atlassian.net/wiki/spaces/SPACEFLOW/pages/38174823/Spaceflow+Coding+Standards+Guidelines)

### Publisher Checklist

1. - [ ] Title is set correctly
1. It contains Jira issue key if possible i.e. `SF-1234 XXX`
2. It contains brief description of the change i.e. `SF-1234 Add create poll command`
2. - [ ] Commits are meaningful
1. Every commit is self-contained
2. Every commit has meaningful commit message
3. - [ ] The Merge Request is either final or has **WIP:** or **Draft:** tag
4. - [ ] At the time of publishing, this branch is rebased onto **master** branch
5. - [ ] Before publishing, local checks have been run via `make check` or `make reset check`
6. - [ ] The linked Jira issue is in status **Code Review**

### Reviewer Checklist
1. - [ ] Code logic is correct
2. - [ ] Classes, Methods & Variables have adequate names
3. - [ ] The code is readable and easy to understand by human. If it's harder, there are comments
4. - [ ] There are no unnecessary code duplicates
5. - [ ] There is no commented or unnecessary code
6. - [ ] The code takes full advantage out of frameworks/libraries and we're not reinventing the wheel
7. - [ ] Both happy path **and** failure possibilities are considered
8. - [ ] Critical spots are correctly logged into logger
9. - [ ] Inputs are sanitized and validated
10. - [ ] Sensitive information is handled properly
11. - [ ] There is no premature optimization, but code performance is considered
12. - [ ] SQLs do not allow any injections
13. - [ ] SQLs are brief and non-convoluted if possible. If not, they are documented and covered by test cases
14. - [ ] Code is covered by unit tests and they also pass points above