# 2022-11-08 Sculpt/Texture/Paint Module Meeting

Note: If you're planning to join the meeting, feel free to add talking points to the agenda.

## Attendees

- Julien
- Joe
- Daniel
- Ramil

## Agenda

### Since Last Meeting

- [⚙ D16335 Sculpting & Painting: High level changes and new Sculpting Introduction page](https://developer.blender.org/D16335)
Current state of updated manual.
[Download New introduction pages](https://drive.google.com/file/d/1SZ9rQ8FychZP-1-8forFMDgtcEcWxOAo/view?usp=share_link). Start of the rewrite of exisiting pages to fix outdated/mising information and correctly explain mental models.

- [⚙ D16320 Brush Properties Refactor](https://developer.blender.org/D16320)
Can lower the prio of this to work on roll and dyntopo first.

What's the current status of the patch?
Isn't used for everything yet.
UI isn't ready yet.
Pen inputs also need more testing.

We can go for current popover UI design, try it and see where we go from there.

Question of priority?
Both are very useful and foundational for more modes.
Depends on which one takes more time?
Brush proterties refactor could take 2.3 weeks.
So we could focus on proerpties first.

The patch can be split into
- Properties refactor + Input Curves + Unified properties
- Cherry picking UI

Unified property still needs to be implemented as a per mode toggle.

- Auto-Masking UI is done for 3.4. Any additional changes are for 3.5.

Propagation steps still need to be amde global. Will add a task for that.

We should start collecting demo material and update Release Notes.
Ramil has ideas for the Area Normal auto-masking demo showcase.
Julien has demo files and ideas for cavity masking

- [⚙ D16414 Sculpt: Stroke Texture Mapping](https://developer.blender.org/D16414) added for Roll feature
What's the current status?
Getting close to done.
Some bugs still need fixing

Debug visualising is actually nice.
We should visualise the samples curve already on stroke start.
Also will be cahnged into single color for simplicyt

- Small adjustments of naming. Joe can you commit these?
- [⚙ D16409 Fix inconsistent naming for cavity_from_mask operator.](https://developer.blender.org/D16409)
Joe can you commit this for 3.4? We can consider this a "fix".
- [⚙ D16413 Sculpt Mode: Renaming of Show/Hide operators for consistency](https://developer.blender.org/D16413)
Mainly just for the Manual. Not sure how this affects translation. Joe can you commit this to master?

### Needs Commit

- [⚙ D11880 Expose Sculpt Symmetrize Merge Threshold Property In UI](https://developer.blender.org/D11880)
Approvwed for a long time. Should get commit.
- [⚙ D16293 Fix T101914: Weight paint gradient tool did not work with masking active](https://developer.blender.org/D16293)
- [⚙ D16294 Texture Paint: sync adding a new texture slot to the Image Editor](https://developer.blender.org/D16294)
Joe can you commit these two?

### High Prio Bugs

- [⚓ T101203 Regression: Issues with undoing the visibility of face sets in sculpt mode](https://developer.blender.org/T101203)
Should poke Hans to review fix.
But first we have to commit D16225. That patch is a foudnational fix for this bug.
- [⚓ T101743 Regression: Redo panel created on sculpting](https://developer.blender.org/T101743)
Poke Campbell to review fix.
- [⚓ T102209 Regression: Blender crashes in Sculpt Mode when subdividing with the Multiresmodifier to level 7](https://developer.blender.org/T102209)
Joe can you take a look? I could not reproduce.
- [⚓ T102336 Regression: Enabling Dynamic Topology Causes Crash on Plane Mesh](https://developer.blender.org/T102336)
Joe can you take a look?
- [⚓ T102337 Regression: Dragging move gizmo causes crash in sculpt mode](https://developer.blender.org/T102337)
Could not reproduce on Linux. Joe can you take a look?
- [⚓ T102348 Sculpt Mode: Area and Topology auto-masking don't work with Mirror](https://developer.blender.org/T102348)
Joe?

### In Review

- [⚙ D16330 Sculpt: Fix crash with no active brush data-block](https://developer.blender.org/D16330)
- [⚙ D15596 Convert Color Attribute operator](https://developer.blender.org/D15596)
Ramil made updates based on Hans feedback.
Needs more work on master ebcause of recent changes to Attributes.
Ramil will try again and poke Hans.
- [⚙ D16241 UI: Add Vertex Group and Color Attributes selector in 3D Viewport](https://developer.blender.org/D16241)
How to handle Sidebar?
Paint Mode and Attribute Paint would eventually get overhauled solution anywya.
But the UI element shoud be exposed in both sidbar and header.
Needs solution.

Paint Mode:
- [⚙ D15298 Support Automasking For Texture Paint](https://developer.blender.org/D15298)
- [⚙ D14900 PBVH Texture Paint Node Splitting](https://developer.blender.org/D14900)
Jeroen would like this to be reviewed for 3.5
- [⚙ D14970 3D Texturing: Fix seam bleeding.](https://developer.blender.org/D14970)
Jeroen would like this to be reviewed for 3.5

### To Do's

**Joe:**
- Roll texture mapping
- Fix stroke bugs (Like scene spacing)
- Fix Enahnce details brush

**Julien:**
- Manual
- Design tasks for 3.5

**Jeroen:**
- Bug fixes for Eevee/Viewport module.

### Other Topics

- [⚓ T102349 Sculpt Mode: Inverted Box Masking inverts mask instead of clearing mask](https://developer.blender.org/T102349)
Old regression.
Joe can have a look.

#### Cavity & Normal Masking Feedback?
*Sugested by Julien Kaspar*

Any suggestions or notes so far from the team?

Also a conversation on adding a proper mask/disabled mask icon.
Julien will do mroe sketches and exploration.


E seems to be the favorit for reability and generic meaning of Mask.
Needs to be more square.

#### Operators in Sculpt Mode
*Sugested by Julien Kaspar*

Joe worked on proper redo support.
Filters, Gestures and other Active Tools were implemented in toolbar because of porevious redo limitations?

Do we want to focus some time to adding Filters, Gestures and Edit tools as menu operators with redo options?
Various advantages:
- Support exisiting [Operate -> Settings](https://wiki.blender.org/wiki/Human_Interface_Guidelines/Paradigms) paradigms from other modes in sculpt mode
- Easier to use various tools as one time operations instead of makign them active
- Easier to use filters via shortcuts and quick favorites.
- Redo panel interactions for very high res meshes (Better with slow performance)
- No need to implement [⚓ T97959 Color Filter: Sliding UI](https://developer.blender.org/T97959) yet

Everyone seems to agree.
Joe thinks that can be done.
What work and what doesn't needs to be tested.

Smooth Filter is already optimised so performance is not that big of a deal.

Vital to fix [⚓ T99607 Resolve "Shift R" shortcut conflict](https://developer.blender.org/T99607) then.
Fast redoing will become an important operation in Sculpt Mode.

We can soon cahnge teh shortcut to `R`.
Rotate and old popup is not as needed.

#### Transform Pivot

Make task for setting pivot location via shortcut and tool settings.
Also to change the orientation of the sculpt session pivot.

#### Enforce LCS in Sculpt Mode
*Sugested by Julien Kaspar*

This would solve common shortcut inconsistencies and conflicts:
- W/RC for context menu vs Face Set pie menu
- `Ctrl-Shft` & `Ctrl` `RC` to mask vs modifers with `LC`
- Shift RC for 3D cursor vs unavailbile

Sculpt Mode (and eventualy Paint Mode) wouldn't have usual "Selection" workflow.
So it can stand outside of the LCS/RCS preference.

Shift RC could then consistently be assigned to set the sculpt-session pivot point instead.
Then [⚙ D9540 Sculpt: Option to transform only the sculpt pivot](https://developer.blender.org/D9540) can land too.

#### Invert Expand behavior
*Sugested by Julien Kaspar*

Make expand more consistent with other masking tools:
- Invert On
- Preserve Previous Off

Make the operator more useful for repeated fast masking of multiple areas and face sets. (No need to press F and E every time)
Makes the main use cases easier to understand.
-> [More in this video](https://drive.google.com/file/d/15LI-4YwVdtXtGm6b9mHS8VN-T4jtZTtO/view?usp=share_link)

Later we can revisit the current behavior with [⚓ T97903 Invert Masking behaviour for Sculpt/Paint Mode](https://developer.blender.org/T97903).

#### Color Expand

- Add it to the menu (So user scan add shortcut more easily)
- Add Paint menu for it and color filters

#### Sculpt-Dev for testing

- Daniel reports crashes in sculpt-dev branch
- For features that are ready for master we can make separte branches for testing
- Many sculpt-dev features are only working in sculpt-dev
- Joe: Sculpt-dev allows testing features without breaking master. Iteratively fix and refine outside of master.
- Also freeer and easier to work with than loose patches.
- Julien: We need to communicate the purpose of the branch. It should not be exposed as the "Proper way to use sculpt mode".
- Joe: Main purpose is to test refactors.
- Ramil: What about undeveloped features. They could eb romved or hidden from the UI, because they don't require testing.
- It will also make the rbanch more stable.
- Joe: Other features like UV maps and array brush also fall into this.
- Some refactors can also be reverted.
- We can highlight the features in sculpt-dev that need proper testing in work environment.
- Julien: Splash could mention features that are in development and can be tested (Easier to find). Other features can be hidden from UI (Or removed if we don't intend to work on them).
- Joe: Will think about it further. We'll revisit this another time since it's not a priority.
- Make it clearer that this is an open prototyping branch
- Especially useful if new feature rely on unfinished refactors.