# Low severity issues ## Issue #293 - Rebasing tokens - checkEnough [Resolved] - pool option maturity in initialize function [X] - strike == 0 check at other places - Bumping the version for oz for 4.73 [X] - unused returns [Not important] - typos in natspec [Not important] ## Issue #286 - Update oz to 4.8.0 for a patch in ERC721Enumerable [X] - Unused imports/libraries [Not important] - Dont use floating pragma [X] - Commented out console log [Not important] - event for collect state change ## Issue #282 - Bumping the version for oz for 4.73 - Update solidity version - Natspec missing for liquidityToken [X] - Use ownership for math libraries - Update the event for two step ownership with old/new values [X] ## Issue #280 - Floating pragma - zero address check for optionFactory - Natspec errors ## Issue #273 - Separate getWithCheck - namingConvention ## Issue #271 - option transferPosition when msg.sender is to address - wrong comments ## Issue #267 - Unchecked cast - inconsistency with solidity docs - console log in timeswapV2Token [X] - @title missing in natspec [X] - comments spacing - spelling mistakes [X] ## Issue #256 - Incorrect uint type in the error library [X] - zero address vulnerability in poolFactory - unsafe subtraction in calculateGivenLogIn [X] - incorrect fee intializationw - erc1155 increment ## Issue #243 - Typos - Periods shouldnt be there in comments - solidity version to be bumped up - return statement doesnt need named returns - pragma should be fixed and not floating [X] ## Issue #239 - return statements shouldnt be mixed with named returns - order of functions is wrong with respect to the style doc - Natspec missing in a few places [X] - typos - line length too long ## Issue #235 - Duplicate file names ## Issue #232 - Whitespace is inconsistent - casing style is inconsistent - Natspec coverage to be increased - use delete instead of zero to clear variables - pragma version is floating [X] - unused returns - code headers could be added - typos ## Issue #230 - console.log present [X] - renentrancy gaurd is not consistent - numberOfPairs is a misleading name ## Issue #214 - gaurd function could be abstracted - cleanup console log [X] - modularize the logic in mint and burn - typos [X] - floating pragma [X] ## Issue #212 - Lock of all pool factory' pools protocol fees if pool factory get deployed with 0 address as chosenOwner ## Issue #199 - Incorrect natspec [X] - line length - use delete variables - zero value checks not implemented well - typos [X] - inconsistent unused name return - Error in L63 TimeswapVPoolFactory.sol [X] ## Issue #189 - package versions to be bumped [X] - specific imports [X] - remove imports for forge-std [X] - public/external conflicts - constants should be utilised more - inconsistent spacing - line length is too long - floating pragma [X] - typos [X] - some files are missing natspec [X] - delete instead of overwriting - more fuzz testing - better test coverage ## Issue #183 - mixin different compiler with outdated versions [X] - Abstract for base contracts - use constants more - integer overflow from unsafe casting ## Issue #170 - non standard tokens not supported - safecast is not used in pool.sol - initialise can be front run - reentrancy missing for collect, burn [X] - pragma float [X] - more recent solidity version - events to be emitted before external calls - Unbounded loop for state/storage variables [X] - address(0) check missing for transferLiquidity [X] - unused return variables - natspec missing in certain areas [X] - order function doesnt match the solidity style docs - line length - console logs [X] ## Issue #161 - zero address validation in constructor ## Issue #154 - inapproriate revert [X] - override specifier can be ommited [X] - ## Issue #152 - missing sanitity check for immutable variables ## Issue #20 - Solidity version 0.8.14 may have the optimiser bug - use _SafeMint instead of _mint - missing parameter validation - remove unused code