That is an early draft, so please add comments or correct errors directly. # Reviewer guidelines * Keep in mind that your role is to prevent new bug introduction or lowering the **existing** code quality. * As a reviewer you are there not to prevent or delay a change but to **help it succeed**. * **Avoid mirroring other reviewers**. You are not adding much value if you wait for other to act act first and only agree with them. * If you do not find yourself able to review a particular change, just mention it via a comment and **remove yourself** from the reviewers list, potentially mentioning those that should be able to do it. * Avoid requiring subjective changes, the change should not look like you wroted. Accept OP style **unless** it is clear bug. * **Avoid formatting/style discussions** on changes that are not about it. If you want to enforce a particular formatting or style propose a change to our linting jobs. * Bad: "Add an extra semicolon on this line" * Good: Shut-up and file a issue/PR to enforce the style. * **Be explicit** when requiring rephrasing by giving at least one example that you would find better. * Bad: *"I find PR title misleading/incorrect"* * Good: *"How about renaming PT to '...'?"* * Keep in mind that **PRs do not need to reach perfection**, they only need to bring the codebase to a better state than before. * Performing reviews in timely manner is likely one of the best ways a core can help a project. It does **motivate others to help with maintenance** and maybe to become regular contributors/maintainers. ## Signs you are not a good reviewer * You quickly approve reviews that contain serious bugs, likely that you are doing a supperficial job * People avoid to add you as a reviewer. Maybe you are too much of a PITA or fail to provide useful feedback. * You are flooding PRs with comments and requests. * You forget to revise your review once the OP did act on your comments. That is important especially for reviews that already in progress. Keep them rolling! * Your subjects become frustrated, loosing hope that their change will ever get merged.