# iOS PR Status [Open PR's](https://github.com/dsg-photon/mono-ios/pulls) ##### Legends: * 🔴♻️ - Change requested * 🛑 - Not following coding standards * 🔎 - under review * 📝 - Comment, * ✅ - Approved not merged. * 📬 - resubmitted for review * 💥 - conflicts * ⏸ - Paused Review * 💬 - Discussion needed | 📐 - PR meeting candidate * 👌 - Self reviewed. * ⚡️ - Photon Reviewed and Merged (LOC 100 > |addition| + |deletion|) * 💯 - Siva to Review * 🟢 DSG review passed. * ❗️ DSG post merge review failed. * 📨 - Ran test script * ❌ - Failed Swiftlint error checks * 🟨 - Photon's comments are open * ⚙️ - Dev working on it * ⬆️ - High priority PR * 🔬 - Def Method reviewed ------------------------------------ ### Critical PR Priority list ⏰ (Only PRs that fix broken state) 🥇 🥈 🥉 https://github.com/dsg-photon/mono-ios/pull/2429 ⚪️👌🏈 [CMT-5438] Add recent PDP/SAYT folders to SANDBOX env plist to fix SANDBOX builds (needed to unblock SANDBOX ticket testing) 🎖 ** Hotfix Queue** 🎖 1. https://github.com/dsg-photon/mono-ios/pull/2435 ⛳️👌🏈 [CMT-5891] GG Scheduler Appointment Creation Fix (2.3.2 Hotfix Release branch) ----- ⚠️ Now on not separate queues for PR. Mention ⚽️ for DSG app, ⛳️ for GG and ⚪️ for white label app --- 🎖 **WhiteLabel Release Queue** 🎖 1. https://github.com/dsg-photon/mono-ios/pull/2424 ⚪️👌🏈 [CMT-5836] Gifting toggle/Shipping toggle fix <- 10. https://github.com/dsg-photon/mono-ios/pull/2437 ⚪️👌 [CMT-5312] checkout key expiry scenario handling 11. https://github.com/dsg-photon/mono-ios/pull/2442 ⚪️👌🏈📨 [CMT-5421] Separating DSGCoreTestUtils framework, adding AnalyticsMock <- 13. https://github.com/dsg-photon/mono-ios/pull/2447 ⚪️👌🏈📬 [CMT-5859] Shimmer effect revision - 📐 14. https://github.com/dsg-photon/mono-ios/pull/2451 ⚪️👌🏈📬 [CMT-5614] Fix error logic and UI for invalid account first/last name 15. https://github.com/dsg-photon/mono-ios/pull/2453 ⚪️👌🏈📨 FB QA build failure fix 16. https://github.com/dsg-photon/mono-ios/pull/2454 ⚪️👌[CMT-5847] Base Changes for Maintaining Different States of Button Styles 17. https://github.com/dsg-photon/mono-ios/pull/2456 ⚪️👌🏈📨[CMT-5842] 3x points-unit tests fix 18. https://github.com/dsg-photon/mono-ios/pull/2460 ⚪️👌 19. https://github.com/dsg-photon/mono-ios/pull/2462 ⚪️👌🏈📨[CMT-5893] BOPIS OMW home screen UI changes 20. https://github.com/dsg-photon/mono-ios/pull/2468 ⛳️👌💯 21. https://github.com/dsg-photon/mono-ios/pull/2464 ⚪️👌💯 [CMT-5816] 22. https://github.com/dsg-photon/mono-ios/pull/2470 ⚪️👌🏈📨[CMT-5383] Call Identity Service for First Name-iOS 14 issue 23. https://github.com/dsg-photon/mono-ios/pull/2473 ⚪️👌💯 [CMT-5823] Account-SC Edit- Phone number and email error message UI 24. https://github.com/dsg-photon/mono-ios/pull/2479 ⚪️👌💯 [CMT-4713] Move points history state fixes #2479 25. https://github.com/dsg-photon/mono-ios/pull/2483 ⛳️👌 [CMT-5926] Automation Issue - Scheduler 26. https://github.com/dsg-photon/mono-ios/pull/2486 ⚪️👌 [CMT-4713] Move points history state fixes 27. https://github.com/dsg-photon/mono-ios/pull/2488 ⚪️👌📬 [CMT-5937] Create Separate Button Types (Primary, Secondary, Tertiary) 28. https://github.com/dsg-photon/mono-ios/pull/2476 ⛳️👌 [CMT-5923] GG | Scheduler | Created New account in Scheduler page, Contact Information are not updated in Contact Information section(Form1) 29. https://github.com/dsg-photon/mono-ios/pull/2489 ⚪️👌💯 [CMT-5924] Tab Icons updated 30. https://github.com/dsg-photon/mono-ios/pull/2493 ⚪️👌 HomrUI Issue 31. https://github.com/dsg-photon/mono-ios/pull/2494 ⚪️👌 32. https://github.com/dsg-photon/mono-ios/pull/2495 ⚪️👌🏈📨[CMT-5667] BOMW Instore Order Summary UI changes 33. https://github.com/dsg-photon/mono-ios/pull/2496 ⚽️👌🏈 [CMT-5791] Link Release Calendar 34. https://github.com/dsg-photon/mono-ios/pull/2499 ⛳️👌 35. https://github.com/dsg-photon/mono-ios/pull/2497 ⚪️👌💯 [CMT-5921] 36. https://github.com/dsg-photon/mono-ios/pull/2500 ⚪️👌💯 [CMT-5865] 37. https://github.com/dsg-photon/mono-ios/pull/2501 ⚪️👌🏈📨 Adding DSGCoreTestUtils framework to all Test targets to avoid build issues 38. https://github.com/dsg-photon/mono-ios/pull/2505 ⚪️👌🏈 [CMT-5942] Add Track State Analytics For Shop Home 39. https://github.com/dsg-photon/mono-ios/pull/2498 ⚪️👌 [CMT-4560] 40. https://github.com/dsg-photon/mono-ios/pull/2506 ⚪️👌 [CMT-5938] 41. https://github.com/dsg-photon/mono-ios/pull/2510 ⚪️👌💯 [CMT-5312] checkout expiry redirection 42. https://github.com/dsg-photon/mono-ios/pull/2511 ⚪️👌🏈📨 [CMT-5457] Simplify Or Conditions Using Equatable oneOf 43. https://github.com/dsg-photon/mono-ios/pull/2512 [CMT-4891] Dismiss Nike Activation Screen after login. kindly review PR ⚽️👌 44. https://github.com/dsg-photon/mono-ios/pull/2517 ⚪️👌💯 [CMT-5495] SAYT Animation 45. https://github.com/dsg-photon/mono-ios/pull/2521 ⚪️👌💯 [CMT-5963] APT missing in Checkout 46. https://github.com/dsg-photon/mono-ios/pull/2528 ⚪️👌🏈 [CMT-5697] App Icon Change Analytics 47. https://github.com/dsg-photon/mono-ios/pull/2529 ⚪️👌🏈📨 [CMT-5182] Fix Feature Flag Decoding Warnings on Tests 48. https://github.com/dsg-photon/mono-ios/pull/2524 ⚪️👌💯 [CMT-5977] XCode thread warning in Cart 49. https://github.com/dsg-photon/mono-ios/pull/2535 ⚪️👌🏈 [CMT-5791] Additional Static Redirect for Sneaker Release 50. https://github.com/dsg-photon/mono-ios/pull/2536 ⚪️👌🏈 [CMT-5550] Login/Create Account Analytics Action 51. https://github.com/dsg-photon/mono-ios/pull/2527 [CMT-5990] DSG | Customize PDP | Unable to customize the product, it opens blank screen on tapping customize it button. ⚪️👌 📬 52. https://github.com/dsg-photon/mono-ios/pull/2565 ⚪️👌💯 [CMT-5735] AVS check for signin user in Checkout 53. https://github.com/dsg-photon/mono-ios/pull/2551 ⚪️👌🏈 [CMT-5731] Highlight Available Rewards + Refactor To DSGUI Component 54. https://github.com/dsg-photon/mono-ios/pull/2552 ⚪️👌🏈📨 DSGUI Swiftlint warnings - fixed 55. https://github.com/dsg-photon/mono-ios/pull/2559 ⚪️👌🏈📨 DSG/GG Swiftlint warnings - fixed 56. https://github.com/dsg-photon/mono-ios/pull/2560 ⚪️👌💯 [CMT-6002] Cart Header flicker issue 57. https://github.com/dsg-photon/mono-ios/pull/2561 ⛳️👌 [CMT-5961] Use ColorPalette for Scheduler module 58. https://github.com/dsg-photon/mono-ios/pull/2566 ⚪️👌 [CMT-5958] Use ColorPalette for CartNCheckout module 59. https://github.com/dsg-photon/mono-ios/pull/2569 ⚪️👌💯 [CMT-5962] Use ColorPalette for Onboarding and Move module 60. https://github.com/dsg-photon/mono-ios/pull/2572 ⚪️👌 Test cases failure fixes in CartNCheckout & DSGUI 61. https://github.com/dsg-photon/mono-ios/pull/2576 ⚪️👌💯 [CMT-5495] 62. https://github.com/dsg-photon/mono-ios/pull/2579 ⚪️👌🏈📨 [CMT-5980] Ability to change Discover Tab title from Remote Config 63. https://github.com/dsg-photon/mono-ios/pull/2590 ⚪️👌 [CMT-5960] Replace hardcoded color names with palette constants - Account Module 64. https://github.com/dsg-photon/mono-ios/pull/2593 ⚪️👌💯 https://github.com/dsg-photon/mono-ios/pull/2593 65. https://github.com/dsg-photon/mono-ios/pull/2591 ⚪️👌 [CMT-5927] CartNCheckoutServices creation 66. https://github.com/dsg-photon/mono-ios/pull/2606 ⚪️👌💯 [CMT-6039] DSG and GG >> Search >> Bar code scan >> Tab nav missing 67. https://github.com/dsg-photon/mono-ios/pull/2624 ⚪️👌 [CMT-6013] APT/Suite/Unit separted in Account/Checkout 68. https://github.com/dsg-photon/mono-ios/pull/2632 ⛳️👌💯 [CMT-5985] Move Scheduling V2 Endpoint 69. https://github.com/dsg-photon/mono-ios/pull/2637 ⚪️👌 [CMT-6116] Checkout scorecard invalid error 70. https://github.com/dsg-photon/mono-ios/pull/2644 ⚪️👌 [CMT-5983] Pre-Order on Cart 71. https://github.com/dsg-photon/mono-ios/pull/2702 ⚪️👌 [CMT-6122] fixed order confirmation slides back issue on iOS 16 #2702 72. https://github.com/dsg-photon/mono-ios/pull/2701 ⚪️👌 [CMT-6122] fixed order confirmation slides back issue on iOS 16 #2702 73. https://github.com/dsg-photon/mono-ios/pull/2708 ⚪️👌💯 [CMT-6147] alignment issue fixed in scheduler service list #2708 74. https://github.com/dsg-photon/mono-ios/pull/2726 ⚪️👌💯 [CMT-5675] shipping name added for logged in user 75. https://github.com/dsg-photon/mono-ios/pull/2672 ⚪️👌 [CMT-6106] updated sandbox environment for apple pay. 76. https://github.com/dsg-photon/mono-ios/pull/2750 ⚪️👌💯 [CMT-6261] gifting address autocomplete issue #2750 77. 🎖 **Features PR Queue** 🎖 1. https://github.com/dsg-photon/mono-ios/pull/2452 [CMT-5788] ⬆️⚪️👌🏈 Homr FullStory bug fix 2. https://github.com/dsg-photon/mono-ios/pull/2449 [CMT-5788] ⚪️👌🏈 Homr redesign 3. 4. https://github.com/dsg-photon/mono-ios/pull/2438 [CMT-5750] ✅⬆️ Homr FullStory component 5. https://github.com/dsg-photon/mono-ios/pull/2429 [CMT-5438] ⚪️👌 Add new PDP/SAYT config folders to SANDBOX environment.plist file 6. https://github.com/dsg-photon/mono-ios/pull/2270 - Develop ⚪️👌 ⬆️ [ON HOLD] 7. https://github.com/dsg-photon/mono-ios/pull/2308 - 👌[CMT-5244] 8. https://github.com/dsg-photon/mono-ios/pull/2301 - 👌[CMT-4602] 9. https://github.com/dsg-photon/mono-ios/pull/2266 - 👌[CMT-1908] 10. https://github.com/dsg-photon/mono-ios/pull/2410 - 👌[CMT-5852] 11. https://github.com/dsg-photon/mono-ios/pull/2434 ⛳️👌🏈 [CMT-5891] GG Scheduler Appointment Creation Fix (develop branch) 12. https://github.com/dsg-photon/mono-ios/pull/2422 ⚪️👌 [CMT-5847] Button Style Changes 13. https://github.com/dsg-photon/mono-ios/pull/2440 ✅ break out carousel into individual spots 14. https://github.com/dsg-photon/mono-ios/pull/2450 ⚪️👌💯 [CMT-4281] unused urls removed 15. https://github.com/dsg-photon/mono-ios/pull/2458 [CMT-5825] Gold Exclusive PDP - Guest View ⚪️👌📬16. https://github.com/dsg-photon/mono-ios/pull/2485 ⚪️👌🏈📨[CMT-5827] Gold Exclusive PDP - SignedIn, Gold member 17. https://github.com/dsg-photon/mono-ios/pull/2491 ⚪️👌🏈 [CMT-5678] Added screen for changing app icon and ability to set alternate icons 18. https://github.com/dsg-photon/mono-ios/pull/2540 ⚽️👌📬 [CMT-5668] Marketing spots added to sneaker calendar 19. https://github.com/dsg-photon/mono-ios/pull/2584 ⚪️👌 [CMT-5550] Analytics - Adding analytics events to AccountLogin/Account Create ## Recently Merged ## ### Week June 11 - July 15 1. https://github.com/dsg-photon/mono-ios/pull/2466 ⚪️👌💯 [CMT-5919] 2. https://github.com/dsg-photon/mono-ios/pull/2467 ⛳️👌💯 [CMT-5866] Scheduler Analytics 3. https://github.com/dsg-photon/mono-ios/pull/2472 ⚪️👌💯 4. https://github.com/dsg-photon/mono-ios/pull/2474 ⚪️👌💯 [CMT-5312] Checkout expiry gift card state handled ### Week June 4 - July 8 :::spoiler **Details** 1. https://github.com/dsg-photon/mono-ios/pull/2426 ⛳️💯👌 [CMT-5876] Scheduler UI Bug 2. https://github.com/dsg-photon/mono-ios/pull/2427 ⚪️👌💯 [CMT-5878] Managed Shortcuts UI Issues 3. https://github.com/dsg-photon/mono-ios/pull/2425 ⚪️👌💯 [CMT-5376] Global UI Issues 4. https://github.com/dsg-photon/mono-ios/pull/2360 ⚪️👌🏈📨 [CMT-5333] Add caching for Move Activity Data - 📬 5. https://github.com/dsg-photon/mono-ios/pull/2431 ⚪️👌💯 [CMT-5376] Global UI Issues 6. https://github.com/dsg-photon/mono-ios/pull/2432 ⛳️💯👌 [CMT-5674] 7. https://github.com/dsg-photon/mono-ios/pull/2428 ⚪️👌💯 [CMT-5222] Store list shimmer 8. https://github.com/dsg-photon/mono-ios/pull/2418 [CMT-5751] ⚪️👌🏈📨 Homr Heading from Remote config. 9. https://github.com/dsg-photon/mono-ios/pull/2436 ⚪️👌💯 [CMT-5222] Store list shimmer 10. https://github.com/dsg-photon/mono-ios/pull/2388 ⚪️👌🏈📨 [CMT-5739] Accounts - Order Details Screen | Pickup Person row is not displaying -📬 11. https://github.com/dsg-photon/mono-ios/pull/2413 [CMT-5818] - Simple Account Contact Info 5. https://github.com/dsg-photon/mono-ios/pull/2419 [CMT-5729] - Apple Wallet Crash 6. https://github.com/dsg-photon/mono-ios/pull/2421 ⚪️👌🏈 [CMT-5653] PDP Properly load images for some products 7. https://github.com/dsg-photon/mono-ios/pull/2420 ⚽️👌🏈 [CMT-5861] Fix Onboarding Not Opening MOVE Connect Tracker View 8. https://github.com/dsg-photon/mono-ios/pull/2441 ⚪️👌💯 ::: ## Recently Merged ## ----- 🔗 [Click here to see the list of previous weeks PRs] 1. https://hackmd.io/pnXJYJKMQ4WBCpAl7nNhBw?view 2. https://hackmd.io/-Wv7nPdJTcqytTwxCd5vkA -----