--- tags: mstu5003, 2019, review --- # Code Review HTML/CSS 2019 Review each others code and log your collective (organized) comments and findings here. ## Structure and Semantics :::info - Is the page divided and organized into clear conceptual boundaries through html markup? - Do element choices accurately mark-up the semantic context of the content? ::: :::success * Yes. All the team members organize the boundaries well and the content is very straight forward. * Yes. We all used Bootstrap to make the webpage more organized and mobile friendly. Noticed that Joanna and Maho used `<nav>`element to make a navigation bar. ::: :::success * Yes. We have our conceotual boundaries organized. * We used `<li>`element and `<!-->` element to organize our html code into different sections. ::: ## Syntax and Readability :::info - Are there any code errors? E.g. missing closing tags, mal-formatted attribute value pairs, etc. - No. - Is the code indented properly? - Are uses of white-space e.g. `<div attr="x">` vs. `<div attr = "x">` consistent? - Are succinct, descriptive, comments used? - Are there many redundant/repeating rule sets? - **ADVANCED:** Is the code parsimonious? ::: :::success * No syntax errors found yet. * Yes. * Not consistent. There are some white spaces here and there. We also noticed that some of the dashes and semicolons are missing. * No succinct and descriptive found but comments. Comments were used to separate the sections and easier for editors to make changes later. * Maybe there are easier ways for ``<col>`` (?) * Yes, everything is where they should be right now. ::: ## Classes and Rules :::info - Do class names choices reflect style or intent? - Are there in-line styles? How can they be written as CSS class rules? - Can Bootstrap CSS rules be used in-lieu of custom defined CSS? - Does code overwrite delicate Bootstrap CSS rules? - Are there many redundant/repeating rule sets? - **ADVANCED:** Can CSS rules be re-written and organized more efficiently? ::: ## Learning :::info - How did the author go about "learning" to code? ::: :::success - Googling things and using the Boostrap website ::: :::info - Are the strategies and approaches used different than the way you approached it? - What are some best practices you can come up with? ::: ## Questions you may have: - Enter here.