---
# System prepended metadata

title: yvYFI War Room Notes

---

# yvYFI War Room Notes

## Issue Overview
- An accounting error in `StrategyMakerYFIDAIDelegate` strategy has caused an inflated pricePerShare in yvYFI vault.
- This same code error appears in `StrategyMakerETHDAIDelegate` (yvETH v2) but has not led to any actual pricePerShare accounting issues at this time.
 
## Issue Timeline

1. A [large deposit](https://etherscan.io/tx/0xf25e3a556e35c1f9c60a5ca44f863db9a3de75efb5287e05ac6673c801549613) is made to yvYFI
1. [Next harvest](https://etherscan.io/tx/0xaad939b86b1a6c9d5e478588608c7eb62a28f120ccf071f1cc419d6b85d68813) did not utilize full YFI balance to fill Maker vault, leaving 295 YFI idle in the strategy contract
    - [issue in code is here](https://github.com/orbxball/yfi-maker/blob/e5cc49256b2b6d6f654374a3df98e7ebdaa862e7/contracts/Strategy.sol#L151). Short-circuits before depositing full amount.
1. Idle YFI sitting in strategy is reported as [profit](https://github.com/orbxball/yfi-maker/blob/29f33721cb4ba00200db0b25e74401308281afd8/contracts/Strategy.sol#L121) on [next harvest](https://etherscan.io/tx/0x0603adc7020c93dfa207b9cc00d4474fb6767ae2f0caf1aa7db64bf23cd67822). Causing share price to shoot up and fees to be taken out; approximately 60 YFI

## Fix
1. Strategist MS attempts to remove strategy from withdraw queue. 
    - This failed for an unknown reason, potentially due to a UI bug in gnosis?
2. Deploy new strategy to fix issues
    - Done for both YFI and WETH
3. Create script to unwrap yvYFI and send back extra "fees" to strategy to correct accounting
4. Migrate to fixed version of strategies for YFI and WETH Maker strategies. YFI share price is restored to normal levels.

## Outstanding Questions
1. Why setting gen lender debt ratio to 10_000 caused harvest to fail
1. Why revoke + harvest in YFI Maker strategy didn't work